Make more use of generated code in analysis server.

pkg/analysis_server/lib/src/protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protocol;
 
 import 'dart:collection';
 import 'dart:convert' show JsonDecoder;
 
 import 'package:analysis_server/src/services/json.dart';
@@ skipping 224 matching lines @@
    * by a `analysis.updateOptions` [request] that includes an unknown analysis
    * option.
    */
   Response.unknownOptionName(Request request, String optionName)
     : this(request.id, error: new RequestError('UNKNOWN_OPTION_NAME', 'Unknown analysis option: "$optionName"'));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by an error during `analysis.getErrors`.
    */
-  Response.getErrorsError(Request request, String message)
+  Response.getErrorsError(Request request, String message,
+      Map<String, Object> result)
     : this(
         request.id,
-        error: new RequestError('GET_ERRORS_ERROR', 'Error during `analysis.getErrors`: $message.'));
+        error: new RequestError('GET_ERRORS_ERROR', 'Error during `analysis.getErrors`: $message.'),
+        result: result);
 
   /**
    * Initialize a newly created instance based upon the given JSON data
    */
   factory Response.fromJson(Map<String, Object> json) {
     try {
       Object id = json[Response.ID];
       if (id is! String) {
         return null;
       }
       Object error = json[Response.ERROR];
+      RequestError decodedError;
+      if (error is Map) {
+        decodedError = new RequestError.fromJson(error);
+      }
       Object result = json[Response.RESULT];
-      Response response;
-      if (error is Map) {
-        response = new Response(id, error: new RequestError.fromJson(error));
-      } else {
-        response = new Response(id);
+      Map<String, Object> decodedResult;
+      if (result is Map) {
+        decodedResult = result;
       }
-      if (result is Map) {
-        result.forEach((String key, Object value) {
-          response.setResult(key, value);
-        });
-      }
-      return response;
+      return new Response(id, error: decodedError,
+          result: decodedResult);
     } catch (exception) {
       return null;
     }
   }
 
   /**
-   * Set the value of the result field with the given [name] to the given [value].
-   */
-  void setResult(String name, Object value) {
-    if (result == null) {
-      result = new HashMap<String, Object>();
-    }
-    result[name] = _toJson(value);
-  }
-
-  /**
-   * Set the result to be an empty map.
-   */
-  void setEmptyResult() {
-    result = new HashMap<String, Object>();
-  }
-
-  /**
    * Return a table representing the structure of the Json object that will be
    * sent to the client to represent this response.
    */
   Map<String, Object> toJson() {
     Map<String, Object> jsonObject = new HashMap<String, Object>();
     jsonObject[ID] = id;
     if (error != null) {
       jsonObject[ERROR] = error.toJson();
     }
     if (result != null) {
@@ skipping 192 matching lines @@
    * The name of the JSON attribute containing the result values.
    */
   static const String PARAMS = 'params';
 
   /**
    * The name of the event that triggered the notification.
    */
   final String event;
 
   /**
-   * A table mapping the names of notification parameters to their values.
+   * A table mapping the names of notification parameters to their values, or
+   * null if there are no notification parameters.
    */
-  final Map<String, Object> params = new HashMap<String, Object>();
+  Map<String, Object> params;
 
   /**
    * Initialize a newly created [Notification] to have the given [event] name.
+   * If [params] is provided, it will be used as the params; otherwise no
+   * params will be used.
    */
-  Notification(this.event);
+  Notification(this.event, [this.params]);
 
   /**
    * Initialize a newly created instance based upon the given JSON data
    */
   factory Notification.fromJson(Map<String, Object> json) {
     try {
       String event = json[Notification.EVENT];
       Object params = json[Notification.PARAMS];
       Notification notification = new Notification(event);
       if (params is Map) {
         params.forEach((String key, Object value) {
           notification.setParameter(key, value);
         });
       }
       return notification;
     } catch (exception) {
       return null;
     }
   }
 
   /**
-   * Return the value of the parameter with the given [name], or `null` if there
-   * is no such parameter associated with this notification.
-   */
-  Object getParameter(String name) => params[name];
-
-  /**
    * Set the value of the parameter with the given [name] to the given [value].
    */
   void setParameter(String name, Object value) {
+    if (params == null) {
+      params = new HashMap<String, Object>();
+    }
     params[name] = _toJson(value);
   }
 
   /**
    * Return a table representing the structure of the Json object that will be
    * sent to the client to represent this response.
    */
   Map<String, Object> toJson() {
     Map<String, Object> jsonObject = {};
     jsonObject[EVENT] = event;
-    if (!params.isEmpty) {
+    if (params != null) {
       jsonObject[PARAMS] = params;
     }
     return jsonObject;
   }
 }
 
 /**
  * Instances of the class [RequestHandler] implement a handler that can handle
  * requests and produce responses for them.
  */
@@ skipping 29 matching lines @@
  */
 _toJson(Object value) {
   if (value is HasToJson) {
     return value.toJson();
   }
   if (value is Iterable) {
     return value.map((item) => _toJson(item)).toList();
   }
   return value;
 }