Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: pkg/analysis_server/lib/src/services/refactoring/refactoring.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.refactoring; 5 library services.refactoring;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/services/correction/change.dart'; 9 import 'package:analysis_server/src/protocol2.dart' show SourceChange;
10 import 'package:analysis_server/src/services/correction/status.dart'; 10 import 'package:analysis_server/src/services/correction/status.dart';
11 import 'package:analysis_server/src/services/refactoring/extract_local.dart'; 11 import 'package:analysis_server/src/services/refactoring/extract_local.dart';
12 import 'package:analysis_server/src/services/refactoring/rename_class_member.dar t'; 12 import 'package:analysis_server/src/services/refactoring/rename_class_member.dar t';
13 import 'package:analysis_server/src/services/refactoring/rename_constructor.dart '; 13 import 'package:analysis_server/src/services/refactoring/rename_constructor.dart ';
14 import 'package:analysis_server/src/services/refactoring/rename_import.dart'; 14 import 'package:analysis_server/src/services/refactoring/rename_import.dart';
15 import 'package:analysis_server/src/services/refactoring/rename_library.dart'; 15 import 'package:analysis_server/src/services/refactoring/rename_library.dart';
16 import 'package:analysis_server/src/services/refactoring/rename_local.dart'; 16 import 'package:analysis_server/src/services/refactoring/rename_local.dart';
17 import 'package:analysis_server/src/services/refactoring/rename_unit_member.dart '; 17 import 'package:analysis_server/src/services/refactoring/rename_unit_member.dart ';
18 import 'package:analysis_server/src/services/search/search_engine.dart'; 18 import 'package:analysis_server/src/services/search/search_engine.dart';
19 import 'package:analyzer/src/generated/ast.dart'; 19 import 'package:analyzer/src/generated/ast.dart';
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 /** 118 /**
119 * Validates arguments to check if this refactoring can be performed. 119 * Validates arguments to check if this refactoring can be performed.
120 * 120 *
121 * This check should be quick because it is used often as arguments change. 121 * This check should be quick because it is used often as arguments change.
122 */ 122 */
123 Future<RefactoringStatus> checkInitialConditions(); 123 Future<RefactoringStatus> checkInitialConditions();
124 124
125 /** 125 /**
126 * Returns the [Change] to apply to perform this refactoring. 126 * Returns the [Change] to apply to perform this refactoring.
127 */ 127 */
128 Future<Change> createChange(); 128 Future<SourceChange> createChange();
129 129
130 /** 130 /**
131 * Returs `true` if the [Change] created by refactoring may be unsafe, 131 * Returs `true` if the [Change] created by refactoring may be unsafe,
132 * so we want user to review the [Change] to ensure that he understands it. 132 * so we want user to review the [Change] to ensure that he understands it.
133 */ 133 */
134 bool requiresPreview(); 134 bool requiresPreview();
135 } 135 }
136 136
137 137
138 /** 138 /**
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 * Validates that the [newName] is a valid identifier and is appropriate for 183 * Validates that the [newName] is a valid identifier and is appropriate for
184 * the type of the [Element] being renamed. 184 * the type of the [Element] being renamed.
185 * 185 *
186 * It does not perform all the checks (such as checking for conflicts with any 186 * It does not perform all the checks (such as checking for conflicts with any
187 * existing names in any of the scopes containing the current name), as many 187 * existing names in any of the scopes containing the current name), as many
188 * of these checkes require search engine. Use [checkFinalConditions] for this 188 * of these checkes require search engine. Use [checkFinalConditions] for this
189 * level of checking. 189 * level of checking.
190 */ 190 */
191 RefactoringStatus checkNewName(); 191 RefactoringStatus checkNewName();
192 } 192 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698