Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/computer/error.dart ('k') | pkg/analysis_server/lib/src/domain_completion.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index e20e63345011a02de1f11f352bc9161d504aa25c..8fe7b67c562c6ee3e51dbf43f1edf49ce6417dff 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -6,7 +6,6 @@ library domain.analysis;
import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/computer/computer_hover.dart';
-import 'package:analysis_server/src/computer/error.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_server/src/protocol2.dart';
@@ -35,23 +34,24 @@ class AnalysisDomainHandler implements RequestHandler {
Response getErrors(Request request) {
String file = new AnalysisGetErrorsParams.fromRequest(request).file;
server.onFileAnalysisComplete(file).then((_) {
- Response response = new Response(request.id);
engine.AnalysisErrorInfo errorInfo = server.getErrors(file);
+ List<AnalysisError> errors;
if (errorInfo == null) {
- response.setResult(ERRORS, []);
+ errors = [];
} else {
- response.setResult(ERRORS, engineErrorInfoToJson(errorInfo));
+ errors = AnalysisError.listFromEngine(errorInfo.lineInfo,
+ errorInfo.errors);
}
- server.sendResponse(response);
+ server.sendResponse(new AnalysisGetErrorsResult(errors).toResponse(
+ request.id));
}).catchError((message) {
if (message is! String) {
engine.AnalysisEngine.instance.logger.logError(
'Illegal error message during getErrors: $message');
message = '';
}
- Response response = new Response.getErrorsError(request, message);
- response.setResult(ERRORS, []);
- server.sendResponse(response);
+ server.sendResponse(new Response.getErrorsError(request, message,
+ new AnalysisGetErrorsResult([]).toJson()));
});
// delay response
return Response.DELAYED_RESPONSE;
@@ -64,20 +64,18 @@ class AnalysisDomainHandler implements RequestHandler {
// prepare parameters
var params = new AnalysisGetHoverParams.fromRequest(request);
// prepare hovers
- List<Hover> hovers = <Hover>[];
+ List<HoverInformation> hovers = <HoverInformation>[];
List<CompilationUnit> units =
server.getResolvedCompilationUnits(params.file);
for (CompilationUnit unit in units) {
- Hover hoverInformation =
+ HoverInformation hoverInformation =
new DartUnitHoverComputer(unit, params.offset).compute();
if (hoverInformation != null) {
hovers.add(hoverInformation);
}
}
// send response
- Response response = new Response(request.id);
- response.setResult(HOVERS, hovers);
- return response;
+ return new AnalysisGetHoverResult(hovers).toResponse(request.id);
}
@override
« no previous file with comments | « pkg/analysis_server/lib/src/computer/error.dart ('k') | pkg/analysis_server/lib/src/domain_completion.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698