Make more use of generated code in analysis server.

pkg/analysis_server/lib/src/domain_analysis.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.analysis;
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/computer_hover.dart';
-import 'package:analysis_server/src/computer/error.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/protocol2.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/engine.dart' as engine;
 
 
 /**
  * Instances of the class [AnalysisDomainHandler] implement a [RequestHandler]
  * that handles requests in the `analysis` domain.
  */
 class AnalysisDomainHandler implements RequestHandler {
   /**
    * The analysis server that is using this handler to process requests.
    */
   final AnalysisServer server;
 
   /**
    * Initialize a newly created handler to handle requests for the given [server].
    */
   AnalysisDomainHandler(this.server);
 
   /**
    * Implement the `analysis.getErrors` request.
    */
   Response getErrors(Request request) {
     String file = new AnalysisGetErrorsParams.fromRequest(request).file;
     server.onFileAnalysisComplete(file).then((_) {
-      Response response = new Response(request.id);
       engine.AnalysisErrorInfo errorInfo = server.getErrors(file);
+      List<AnalysisError> errors;
       if (errorInfo == null) {
-        response.setResult(ERRORS, []);
+        errors = [];
       } else {
-        response.setResult(ERRORS, engineErrorInfoToJson(errorInfo));
+        errors = AnalysisError.listFromEngine(errorInfo.lineInfo,
+            errorInfo.errors);
       }
-      server.sendResponse(response);
+      server.sendResponse(new AnalysisGetErrorsResult(errors).toResponse(
+          request.id));
     }).catchError((message) {
       if (message is! String) {
         engine.AnalysisEngine.instance.logger.logError(
             'Illegal error message during getErrors: $message');
         message = '';
       }
-      Response response = new Response.getErrorsError(request, message);
-      response.setResult(ERRORS, []);
-      server.sendResponse(response);
+      server.sendResponse(new Response.getErrorsError(request, message,
+          new AnalysisGetErrorsResult([]).toJson()));
     });
     // delay response
     return Response.DELAYED_RESPONSE;
   }
 
   /**
    * Implement the `analysis.getHover` request.
    */
   Response getHover(Request request) {
     // prepare parameters
     var params = new AnalysisGetHoverParams.fromRequest(request);
     // prepare hovers
-    List<Hover> hovers = <Hover>[];
+    List<HoverInformation> hovers = <HoverInformation>[];
     List<CompilationUnit> units =
         server.getResolvedCompilationUnits(params.file);
     for (CompilationUnit unit in units) {
-      Hover hoverInformation =
+      HoverInformation hoverInformation =
           new DartUnitHoverComputer(unit, params.offset).compute();
       if (hoverInformation != null) {
         hovers.add(hoverInformation);
       }
     }
     // send response
-    Response response = new Response(request.id);
-    response.setResult(HOVERS, hovers);
-    return response;
+    return new AnalysisGetHoverResult(hovers).toResponse(request.id);
   }
 
   @override
   Response handleRequest(Request request) {
     try {
       String requestName = request.method;
       if (requestName == ANALYSIS_GET_ERRORS) {
         return getErrors(request);
       } else if (requestName == ANALYSIS_GET_HOVER) {
         return getHover(request);
@@ skipping 96 matching lines @@
     }
     if (newOptions.generateHints != null) {
       updaters.add((engine.AnalysisOptionsImpl options) {
         options.hint = newOptions.generateHints;
       });
     }
     server.updateOptions(updaters);
     return new Response(request.id);
   }
 }