Run pub tests against older versions of barback.

Run pub tests against older versions of barback.

If we're going to claim to support older versions of barback
indefinitely, we need to test that support. This will become
increasingly important as the glue code for more recent versions
becomes more and more distinct from that for older versions.

This does slow down the time it takes to run all the pub tests by
about 20%. It may be worth considering only running a subset of
barback tests against all versions when running locally.

R=rnystrom@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=36707

[Bob Nystrom, 2014-05-27 17:49:46]

+ricow for the heads up.

Couple of nits, but LGTM! This looks very nice.

https://codereview.chromium.org/291843011/diff/1/sdk/lib/_internal/pub/test/t...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/291843011/diff/1/sdk/lib/_internal/pub/test/t...
sdk/lib/_internal/pub/test/test_pub.dart:80: /// A map from barback versions to
their locations in the repo.
"their locations in the repo" -> "paths of directories in the repo containing
them".

https://codereview.chromium.org/291843011/diff/1/sdk/lib/_internal/pub/test/t...
sdk/lib/_internal/pub/test/test_pub.dart:87: Map<Version, String>
_computeBarbackVersions() {
Nit: "compute" -> "find"?

[nweiz, 2014-05-27 20:40:47]

https://codereview.chromium.org/291843011/diff/1/sdk/lib/_internal/pub/test/t...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/291843011/diff/1/sdk/lib/_internal/pub/test/t...
sdk/lib/_internal/pub/test/test_pub.dart:80: /// A map from barback versions to
their locations in the repo.
On 2014/05/27 17:49:47, Bob Nystrom wrote:
> "their locations in the repo" -> "paths of directories in the repo containing
> them".

Done.

https://codereview.chromium.org/291843011/diff/1/sdk/lib/_internal/pub/test/t...
sdk/lib/_internal/pub/test/test_pub.dart:87: Map<Version, String>
_computeBarbackVersions() {
On 2014/05/27 17:49:47, Bob Nystrom wrote:
> Nit: "compute" -> "find"?

Done.

[nweiz, 2014-05-27 20:42:42]

Committed patchset #2 manually as r36707 (presubmit successful).

[ricow1, 2014-05-28 06:43:56]

First of, testing against older versions of bareback seems really good moving
forward.
A few comments:
Please don't check directly into third_party under bleeding_edge, see
https://code.google.com/p/dart/wiki/ThirdPartyAndBinaryData
for instructions (check it into https://dart.googlecode.com/svn/third_party and
add a DEPS dependency pinned at the revision you are using)

I actually have a nicer solution in this specific case:
Simply add a dependency to the deps file pulling in the old version, something
like this:
https://codereview.chromium.org/302773007/

[nweiz, 2014-05-28 20:29:19]

On 2014/05/28 06:43:56, ricow1 wrote:
> First of, testing against older versions of bareback seems really good moving
> forward.
> A few comments:
> Please don't check directly into third_party under bleeding_edge, see
> https://code.google.com/p/dart/wiki/ThirdPartyAndBinaryData
> for instructions (check it into https://dart.googlecode.com/svn/third_party
and
> add a DEPS dependency pinned at the revision you are using)
> 
> I actually have a nicer solution in this specific case:
> Simply add a dependency to the deps file pulling in the old version, something
> like this:
> https://codereview.chromium.org/302773007/

I can do that. I'm a bit confused, though: it looks like none of the other
packages in third_party/pkg are controlled by DEPS. I don't see them n DEPS, and
third_party/pkg/.gitignore doesn't ignore them, unlike the other directories in
third_party.