Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: sdk/lib/_internal/pub/test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart

Issue 291843011: Run pub tests against older versions of barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart
diff --git a/sdk/lib/_internal/pub/test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart b/sdk/lib/_internal/pub/test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart
index e66023ddb714b879c9316309c0aecf8bc9c7a972..d64b53382427f099822ea8f75191b09fe06bc349 100644
--- a/sdk/lib/_internal/pub/test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart
+++ b/sdk/lib/_internal/pub/test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart
@@ -11,34 +11,36 @@ import '../serve/utils.dart';
main() {
// This is a regression test for issue #17198.
initConfig();
- integration("compiles a Dart file that imports a generated file to JS "
- "outside web/", () {
- d.dir(appPath, [
- d.pubspec({
- "name": "myapp",
- "version": "0.0.1",
- "transformers": ["myapp/transformer"]
- }),
- d.dir("lib", [
- d.file("transformer.dart", dartTransformer("munge"))
- ]),
- d.dir("test", [
- d.file("main.dart", """
+ withBarbackVersions("any", () {
+ integration("compiles a Dart file that imports a generated file to JS "
+ "outside web/", () {
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "version": "0.0.1",
+ "transformers": ["myapp/transformer"]
+ }),
+ d.dir("lib", [
+ d.file("transformer.dart", dartTransformer("munge"))
+ ]),
+ d.dir("test", [
+ d.file("main.dart", """
import "other.dart";
void main() => print(TOKEN);
"""),
- d.file("other.dart", """
+ d.file("other.dart", """
library other;
const TOKEN = "before";
""")
- ])
- ]).create();
+ ])
+ ]).create();
- createLockFile('myapp', pkg: ['barback']);
+ createLockFile('myapp', pkg: ['barback']);
- pubServe(args: ["test"]);
- requestShouldSucceed("main.dart.js", contains("(before, munge)"),
- root: "test");
- endPubServe();
+ pubServe(args: ["test"]);
+ requestShouldSucceed("main.dart.js", contains("(before, munge)"),
+ root: "test");
+ endPubServe();
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698