Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers_test.dart

Issue 291843011: Run pub tests against older versions of barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers_test.dart
diff --git a/sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers_test.dart b/sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers_test.dart
index 20d622b7285825d02d3d27300b633ca1bd49c1ba..ccf5fa5db3394d2d32abe089f86a42a3651de856 100644
--- a/sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers_test.dart
+++ b/sdk/lib/_internal/pub/test/serve/supports_user_defined_declaring_transformers_test.dart
@@ -36,36 +36,38 @@ class DeclaringRewriteTransformer extends Transformer
main() {
initConfig();
- integration("supports a user-defined declaring transformer", () {
- d.dir(appPath, [
- d.pubspec({
- "name": "myapp",
- "transformers": ["myapp/src/lazy", "myapp/src/declaring"]
- }),
- d.dir("lib", [d.dir("src", [
- // Include a lazy transformer before the declaring transformer, because
- // otherwise its behavior is indistinguishable from a normal
- // transformer.
- d.file("lazy.dart", LAZY_TRANSFORMER),
- d.file("declaring.dart", DECLARING_TRANSFORMER)
- ])]),
- d.dir("web", [
- d.file("foo.txt", "foo")
- ])
- ]).create();
+ withBarbackVersions("any", () {
+ integration("supports a user-defined declaring transformer", () {
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "transformers": ["myapp/src/lazy", "myapp/src/declaring"]
+ }),
+ d.dir("lib", [d.dir("src", [
+ // Include a lazy transformer before the declaring transformer,
+ // because otherwise its behavior is indistinguishable from a normal
+ // transformer.
+ d.file("lazy.dart", LAZY_TRANSFORMER),
+ d.file("declaring.dart", DECLARING_TRANSFORMER)
+ ])]),
+ d.dir("web", [
+ d.file("foo.txt", "foo")
+ ])
+ ]).create();
- createLockFile('myapp', pkg: ['barback']);
+ createLockFile('myapp', pkg: ['barback']);
- var server = pubServe();
- // The build should complete without either transformer logging anything.
- server.stdout.expect('Build completed successfully');
+ var server = pubServe();
+ // The build should complete without either transformer logging anything.
+ server.stdout.expect('Build completed successfully');
- requestShouldSucceed("foo.final", "foo.out.final");
- server.stdout.expect(emitsLines(
- '[Info from LazyRewrite]:\n'
- 'Rewriting myapp|web/foo.txt.\n'
- '[Info from DeclaringRewrite]:\n'
- 'Rewriting myapp|web/foo.out.'));
- endPubServe();
+ requestShouldSucceed("foo.final", "foo.out.final");
+ server.stdout.expect(emitsLines(
+ '[Info from LazyRewrite]:\n'
+ 'Rewriting myapp|web/foo.txt.\n'
+ '[Info from DeclaringRewrite]:\n'
+ 'Rewriting myapp|web/foo.out.'));
+ endPubServe();
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698