Chromium Code Reviews

Unified Diff: sdk/lib/_internal/pub/test/transformer/detects_an_ordering_dependency_cycle_test.dart

Issue 291843011: Run pub tests against older versions of barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: sdk/lib/_internal/pub/test/transformer/detects_an_ordering_dependency_cycle_test.dart
diff --git a/sdk/lib/_internal/pub/test/transformer/detects_an_ordering_dependency_cycle_test.dart b/sdk/lib/_internal/pub/test/transformer/detects_an_ordering_dependency_cycle_test.dart
index 15d83829efbea7cdf37aeba6bc515e372106de37..fe973e8ddccb330f1269db61f5c2fa3339c287ef 100644
--- a/sdk/lib/_internal/pub/test/transformer/detects_an_ordering_dependency_cycle_test.dart
+++ b/sdk/lib/_internal/pub/test/transformer/detects_an_ordering_dependency_cycle_test.dart
@@ -10,55 +10,57 @@ import '../serve/utils.dart';
main() {
initConfig();
- integration("detects an ordering dependency cycle", () {
- d.dir("foo", [
- d.pubspec({
- "name": "foo",
- "version": "1.0.0",
- "transformers": ["myapp/transformer"],
- "dependencies": {'myapp': {'path': '../myapp'}}
- })
- ]).create();
+ withBarbackVersions("any", () {
+ integration("detects an ordering dependency cycle", () {
+ d.dir("foo", [
+ d.pubspec({
+ "name": "foo",
+ "version": "1.0.0",
+ "transformers": ["myapp/transformer"],
+ "dependencies": {'myapp': {'path': '../myapp'}}
+ })
+ ]).create();
- d.dir("bar", [
- d.pubspec({
- "name": "bar",
- "version": "1.0.0",
- "dependencies": {'foo': {'path': '../foo'}}
- }),
- d.dir("lib", [
- d.file("transformer.dart", dartTransformer('bar')),
- ])
- ]).create();
+ d.dir("bar", [
+ d.pubspec({
+ "name": "bar",
+ "version": "1.0.0",
+ "dependencies": {'foo': {'path': '../foo'}}
+ }),
+ d.dir("lib", [
+ d.file("transformer.dart", dartTransformer('bar')),
+ ])
+ ]).create();
- d.dir("baz", [
- d.pubspec({
- "name": "baz",
- "version": "1.0.0",
- "transformers": ["bar/transformer"],
- "dependencies": {'bar': {'path': '../bar'}}
- })
- ]).create();
+ d.dir("baz", [
+ d.pubspec({
+ "name": "baz",
+ "version": "1.0.0",
+ "transformers": ["bar/transformer"],
+ "dependencies": {'bar': {'path': '../bar'}}
+ })
+ ]).create();
- d.dir(appPath, [
- d.pubspec({
- "name": "myapp",
- "dependencies": {'baz': {'path': '../baz'}}
- }),
- d.dir("lib", [
- d.file("transformer.dart", dartTransformer('myapp')),
- ])
- ]).create();
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "dependencies": {'baz': {'path': '../baz'}}
+ }),
+ d.dir("lib", [
+ d.file("transformer.dart", dartTransformer('myapp')),
+ ])
+ ]).create();
- createLockFile('myapp', sandbox: ['foo', 'bar', 'baz'], pkg: ['barback']);
+ createLockFile('myapp', sandbox: ['foo', 'bar', 'baz'], pkg: ['barback']);
- var process = startPubServe();
- process.shouldExit(1);
- process.stderr.expect(emitsLines(
- "Transformer cycle detected:\n"
- " bar depends on foo\n"
- " foo is transformed by myapp/transformer\n"
- " myapp depends on baz\n"
- " baz is transformed by bar/transformer"));
+ var process = startPubServe();
+ process.shouldExit(1);
+ process.stderr.expect(emitsLines(
+ "Transformer cycle detected:\n"
+ " bar depends on foo\n"
+ " foo is transformed by myapp/transformer\n"
+ " myapp depends on baz\n"
+ " baz is transformed by bar/transformer"));
+ });
});
}

Powered by Google App Engine