Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: sdk/lib/_internal/pub/test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart

Issue 291843011: Run pub tests against older versions of barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart
diff --git a/sdk/lib/_internal/pub/test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart b/sdk/lib/_internal/pub/test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart
index 81d6c00a194520de84fdbbc25589500d15e9199a..01ac8f0524c15c99f2001d47fb79b4261bf0620f 100644
--- a/sdk/lib/_internal/pub/test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart
+++ b/sdk/lib/_internal/pub/test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart
@@ -12,27 +12,29 @@ import 'utils.dart';
main() {
initConfig();
- integration("doesn't crash if an unused .dart file has a syntax error", () {
- d.dir(appPath, [
- d.pubspec({
- "name": "myapp",
- "transformers": ["myapp/src/transformer"]
- }),
- d.dir("lib", [d.dir("src", [
- d.file("transformer.dart", REWRITE_TRANSFORMER),
- d.file("unused.dart", "(*&^#@")
- ])]),
- d.dir("web", [
- d.file("foo.txt", "foo")
- ])
- ]).create();
+ withBarbackVersions("any", () {
+ integration("doesn't crash if an unused .dart file has a syntax error", () {
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "transformers": ["myapp/src/transformer"]
+ }),
+ d.dir("lib", [d.dir("src", [
+ d.file("transformer.dart", REWRITE_TRANSFORMER),
+ d.file("unused.dart", "(*&^#@")
+ ])]),
+ d.dir("web", [
+ d.file("foo.txt", "foo")
+ ])
+ ]).create();
- createLockFile('myapp', pkg: ['barback']);
+ createLockFile('myapp', pkg: ['barback']);
- var server = pubServe();
- server.stderr.expect("[RewriteImport]:");
- server.stderr.expect(startsWith("Error in myapp|lib/src/unused.dart:"));
- requestShouldSucceed("foo.out", "foo.out");
- endPubServe();
+ var server = pubServe();
+ server.stderr.expect("[RewriteImport]:");
+ server.stderr.expect(startsWith("Error in myapp|lib/src/unused.dart:"));
+ requestShouldSucceed("foo.out", "foo.out");
+ endPubServe();
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698