Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart

Issue 291843011: Run pub tests against older versions of barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart
diff --git a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart
index 6d3e8a84998736d7d489a46f6c32d07d82a37078..0a61e5945598c661b30fad3e551dc76b5030e6d4 100644
--- a/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart
+++ b/sdk/lib/_internal/pub/test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart
@@ -16,23 +16,25 @@ main() {
// A syntax error will cause the analyzer to fail to parse the transformer
// when attempting to rewrite its imports.
- integration("fails to load a transform with a syntax error", () {
- d.dir(appPath, [
- d.pubspec({
- "name": "myapp",
- "transformers": ["myapp/src/transformer"]
- }),
- d.dir("lib", [d.dir("src", [
- d.file("transformer.dart", "syntax error")
- ])])
- ]).create();
+ withBarbackVersions("any", () {
+ integration("fails to load a transform with a syntax error", () {
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "transformers": ["myapp/src/transformer"]
+ }),
+ d.dir("lib", [d.dir("src", [
+ d.file("transformer.dart", "syntax error")
+ ])])
+ ]).create();
- createLockFile('myapp', pkg: ['barback']);
+ createLockFile('myapp', pkg: ['barback']);
- var pub = startPubServe();
- pub.stderr.expect('[RewriteImport]:');
- pub.stderr.expect(startsWith('Error in'));
- pub.shouldExit(1);
- pub.stderr.expect(never(contains('This is an unexpected error')));
+ var pub = startPubServe();
+ pub.stderr.expect('[RewriteImport]:');
+ pub.stderr.expect(startsWith('Error in'));
+ pub.shouldExit(1);
+ pub.stderr.expect(never(contains('This is an unexpected error')));
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698