Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: sdk/lib/_internal/pub/test/transformer/exclusion/works_on_dart2js_test.dart

Issue 291843011: Run pub tests against older versions of barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/transformer/exclusion/works_on_dart2js_test.dart
diff --git a/sdk/lib/_internal/pub/test/transformer/exclusion/works_on_dart2js_test.dart b/sdk/lib/_internal/pub/test/transformer/exclusion/works_on_dart2js_test.dart
index 13e821f7a4581f5871202ec1f3552ed849df832a..a590293e1fb1ddf55167a7079b2f06b8471aa807 100644
--- a/sdk/lib/_internal/pub/test/transformer/exclusion/works_on_dart2js_test.dart
+++ b/sdk/lib/_internal/pub/test/transformer/exclusion/works_on_dart2js_test.dart
@@ -13,40 +13,42 @@ import '../../serve/utils.dart';
main() {
initConfig();
- integration("works on the dart2js transformer", () {
- d.dir(appPath, [
- d.pubspec({
- "name": "myapp",
- "transformers": [
- {
- "\$dart2js": {
- "\$include": ["web/a.dart", "web/b.dart"],
- "\$exclude": "web/a.dart"
+ withBarbackVersions("any", () {
+ integration("works on the dart2js transformer", () {
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "transformers": [
+ {
+ "\$dart2js": {
+ "\$include": ["web/a.dart", "web/b.dart"],
+ "\$exclude": "web/a.dart"
+ }
}
- }
- ]
- }),
- d.dir("web", [
- d.file("a.dart", "void main() => print('hello');"),
- d.file("b.dart", "void main() => print('hello');"),
- d.file("c.dart", "void main() => print('hello');")
- ])
- ]).create();
-
- createLockFile('myapp', pkg: ['barback']);
-
- var server = pubServe();
- // Dart2js should remain lazy.
- server.stdout.expect("Build completed successfully");
-
- requestShould404("a.dart.js");
- requestShouldSucceed("b.dart.js", isNot(isEmpty));
- server.stdout.expect(consumeThrough(emitsLines(
- "[Info from Dart2JS]:\n"
- "Compiling myapp|web/b.dart...")));
- server.stdout.expect(consumeThrough("Build completed successfully"));
-
- requestShould404("c.dart.js");
- endPubServe();
+ ]
+ }),
+ d.dir("web", [
+ d.file("a.dart", "void main() => print('hello');"),
+ d.file("b.dart", "void main() => print('hello');"),
+ d.file("c.dart", "void main() => print('hello');")
+ ])
+ ]).create();
+
+ createLockFile('myapp', pkg: ['barback']);
+
+ var server = pubServe();
+ // Dart2js should remain lazy.
+ server.stdout.expect("Build completed successfully");
+
+ requestShould404("a.dart.js");
+ requestShouldSucceed("b.dart.js", isNot(isEmpty));
+ server.stdout.expect(consumeThrough(emitsLines(
+ "[Info from Dart2JS]:\n"
+ "Compiling myapp|web/b.dart...")));
+ server.stdout.expect(consumeThrough("Build completed successfully"));
+
+ requestShould404("c.dart.js");
+ endPubServe();
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698