Run pub tests against older versions of barback.

sdk/lib/_internal/pub/test/test_pub.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Test infrastructure for testing pub. Unlike typical unit tests, most pub
 /// tests are integration tests that stage some stuff on the file system, run
 /// pub, and then validate the results. This library provides an API to build
 /// tests like that.
 library test_pub;
 
@@ skipping 17 matching lines @@
 import '../lib/src/exit_codes.dart' as exit_codes;
 // TODO(rnystrom): Using "gitlib" as the prefix here is ugly, but "git" collides
 // with the git descriptor method. Maybe we should try to clean up the top level
 // scope a bit?
 import '../lib/src/git.dart' as gitlib;
 import '../lib/src/http.dart';
 import '../lib/src/io.dart';
 import '../lib/src/lock_file.dart';
 import '../lib/src/log.dart' as log;
 import '../lib/src/package.dart';
+import '../lib/src/pubspec.dart';
 import '../lib/src/source/hosted.dart';
 import '../lib/src/source/path.dart';
 import '../lib/src/source_registry.dart';
 import '../lib/src/system_cache.dart';
 import '../lib/src/utils.dart';
 import '../lib/src/validator.dart';
 import '../lib/src/version.dart';
 import 'descriptor.dart' as d;
 
 /// This should be called at the top of a test file to set up an appropriate
@@ skipping 17 matching lines @@
 /// A [Matcher] that matches JavaScript generated by dart2js with minification
 /// enabled.
 Matcher isMinifiedDart2JSOutput =
     isNot(contains("// The code supports the following hooks"));
 
 /// A [Matcher] that matches JavaScript generated by dart2js with minification
 /// disabled.
 Matcher isUnminifiedDart2JSOutput =
     contains("// The code supports the following hooks");
 
+/// The directory containing the version of barback that should be used for this
+/// test.
+String _barbackDir;
+
+/// A map from barback versions to their locations in the repo.

[Bob Nystrom, 2014/05/27 17:49:47]

"their locations in the repo" -> "paths of directories in the repo containing
them".

[nweiz, 2014/05/27 20:40:47]

Done.

+///
+/// This includes the latest version of barback from pkg as well as all old
+/// versions of barback in third_party.
+final _barbackVersions = _computeBarbackVersions();
+
+/// Populates [_barbackVersions].
+Map<Version, String> _computeBarbackVersions() {

[Bob Nystrom, 2014/05/27 17:49:47]

Nit: "compute" -> "find"?

[nweiz, 2014/05/27 20:40:47]

Done.

+  var versions = {};
+  var currentBarback = path.join(repoRoot, 'pkg', 'barback');
+  versions[new Pubspec.load(currentBarback, new SourceRegistry()).version] =
+      currentBarback;
+
+  for (var dir in listDir(path.join(repoRoot, 'third_party', 'pkg'))) {
+    var basename = path.basename(dir);
+    if (!basename.startsWith('barback')) continue;
+    versions[new Version.parse(split1(basename, '-').last)] = dir;
+  }
+
+  return versions;
+}
+
+/// Runs the tests in [callback] against all versions of barback in the repo
+/// that match [versionConstraint].
+///
+/// This is used to test that pub doesn't accidentally break older versions of
+/// barback that it's committed to supporting. Only versions `0.13.0` and later
+/// will be tested.
+void withBarbackVersions(String versionConstraint, void callback()) {
+  var constraint = new VersionConstraint.parse(versionConstraint);
+
+  var validVersions = _barbackVersions.keys.where(constraint.allows);
+  if (validVersions.isEmpty) {
+    throw new ArgumentError(
+        'No available barback version matches "$versionConstraint".');
+  }
+
+  for (var version in validVersions) {
+    group("with barback $version", () {
+      setUp(() {
+        _barbackDir = _barbackVersions[version];
+      });
+
+      callback();
+    });
+  }
+}
+
 /// The completer for [port].
 Completer<int> get _portCompleter {
   if (_portCompleterCache != null) return _portCompleterCache;
   _portCompleterCache = new Completer<int>();
   currentSchedule.onComplete.schedule(() {
     _portCompleterCache = null;
   }, 'clearing the port completer');
   return _portCompleterCache;
 }
 
@@ skipping 535 matching lines @@
     }
   }
 
   if (pkg != null) {
     var pkgDir = path.absolute(path.join(
         path.dirname(Platform.executable),
         '..', '..', '..', '..', 'pkg'));
 
     _addPackage(String package) {
       if (dependencies.containsKey(package)) return;
-      var packagePath = path.join(pkgDir, package);
+
+      var packagePath;
+      if (package == 'barback') {
+        if (_barbackDir == null) {
+          throw new StateError("createLockFile() can only create a lock file "
+              "with a barback dependency within a withBarbackVersions() "
+              "block.");
+        }
+        packagePath = _barbackDir;
+      } else {
+        packagePath = path.join(pkgDir, package);
+      }
+
       dependencies[package] = packagePath;
       var pubspec = loadYaml(
           readTextFile(path.join(packagePath, 'pubspec.yaml')));
       var packageDeps = pubspec['dependencies'];
       if (packageDeps == null) return;
       packageDeps.keys.forEach(_addPackage);
     }
 
     pkg.forEach(_addPackage);
   }
@@ skipping 202 matching lines @@
         _lastMatcher.matches(item.last, matchState);
   }
 
   Description describe(Description description) {
     return description.addAll("(", ", ", ")", [_firstMatcher, _lastMatcher]);
   }
 }
 
 /// A [StreamMatcher] that matches multiple lines of output.
 StreamMatcher emitsLines(String output) => inOrder(output.split("\n"));