Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 266913017: Convert property methods into getters. (Closed)

Created:
6 years, 7 months ago by Johnni Winther
Modified:
6 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Convert property methods into getters. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=35842

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1317 lines, -1321 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 20 chunks +33 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 10 chunks +15 lines, -15 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 16 chunks +33 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 13 chunks +21 lines, -21 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 13 chunks +24 lines, -24 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 10 chunks +17 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dump_info.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 13 chunks +68 lines, -68 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 61 chunks +140 lines, -142 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 15 chunks +31 lines, -31 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/concrete_types_inferrer.dart View 18 chunks +29 lines, -29 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart View 5 chunks +8 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/list_tracer.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/map_tracer.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart View 22 chunks +51 lines, -51 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart View 13 chunks +29 lines, -29 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart View 8 chunks +22 lines, -22 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart View 6 chunks +11 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 21 chunks +34 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 13 chunks +35 lines, -35 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 10 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 17 chunks +23 lines, -23 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 14 chunks +21 lines, -21 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart View 17 chunks +33 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_library_mirror.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart View 1 7 chunks +16 lines, -16 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors_used.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 13 chunks +18 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/patch_parser.dart View 8 chunks +16 lines, -16 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/class_members.dart View 9 chunks +13 lines, -14 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/member_impl.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 84 chunks +146 lines, -146 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/signatures.dart View 6 chunks +12 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolved_visitor.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 6 chunks +13 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 74 chunks +125 lines, -125 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 13 chunks +15 lines, -15 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 9 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 5 chunks +18 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 21 chunks +33 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/function_set.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/universe.dart View 8 chunks +34 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/world.dart View 6 chunks +15 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/codegen_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/members_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/reexport_handled_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
6 years, 7 months ago (2014-05-06 11:49:43 UTC) #1
karlklose
LGTM.
6 years, 7 months ago (2014-05-06 12:36:47 UTC) #2
Johnni Winther
6 years, 7 months ago (2014-05-07 07:53:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698