sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart - Issue 266913017: Convert property methods into getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebased Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart

index dab9bee682abca996e3c06af517a5028debbad52..2ef19a1640320216c989f13910e2688099ffbb8d 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart

@@ -113,10 +113,10 @@ class JavaScriptConstantCompiler extends ConstantCompilerBase

Iterable<VariableElement> getStaticNonFinalFieldsForEmission() {

return initialVariableValues.keys.where((element) {

return element.kind == ElementKind.FIELD &&

- !element.isInstanceMember() &&

- !element.modifiers.isFinal() &&

+ !element.isInstanceMember &&

+ !element.modifiers.isFinal &&

// The const fields are all either emitted elsewhere or inlined.

- !element.modifiers.isConst();

+ !element.modifiers.isConst;

});

}