Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart b/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart
index 8b8d1829cad11742ab99c1935e2944136ea2d890..807b896a002dc336106c20c55eb369fb5d63a43c 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart
@@ -77,7 +77,7 @@ class CustomElementsAnalysis {
// In codegen we see the TypeConstants instead.
if (!enqueuer.isResolutionQueue) return;
- if (element.isClass()) {
+ if (element.isClass) {
// TODO(sra): If we had a flow query from the type literal expression to
// the Type argument of the metadata lookup, we could tell if this type
// literal is really a demand for the metadata.
@@ -91,7 +91,7 @@ class CustomElementsAnalysis {
}
void registerTypeConstant(Element element, Enqueuer enqueuer) {
- assert(element.isClass());
+ assert(element.isClass);
assert(!enqueuer.isResolutionQueue);
codegenJoin.selectedClasses.add(element);
}
@@ -148,7 +148,7 @@ class CustomElementsAnalysisJoin {
if (!demanded) return;
var newActiveClasses = new Set<ClassElement>();
for (ClassElement classElement in instantiatedClasses) {
- bool isNative = classElement.isNative();
+ bool isNative = classElement.isNative;
bool isExtension =
!isNative && Elements.isNativeOrExtendsNative(classElement);
// Generate table entries for native classes that are explicitly named and
@@ -181,10 +181,10 @@ class CustomElementsAnalysisJoin {
// Only classes that extend native classes have constructors in the table.
// We could refine this to classes that extend Element, but that would break
// the tests and there is no sane reason to subclass other native classes.
- if (classElement.isNative()) return result;
+ if (classElement.isNative) return result;
selectGenerativeConstructors(ClassElement enclosing, Element member) {
- if (member.isGenerativeConstructor()) {
+ if (member.isGenerativeConstructor) {
// Ignore constructors that cannot be called with zero arguments.
FunctionElement constructor = member;
FunctionSignature parameters = constructor.functionSignature;

Powered by Google App Engine
This is Rietveld 408576698