Convert property methods into getters.

sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart_backend;
 
 // TODO(ahe): This class is simply wrong.  This backend should use
 // elements when it can, not AST nodes.  Perhaps a [Map<Element,
 // TreeElements>] is what is needed.
 class ElementAst {
@@ skipping 136 matching lines @@
 
   void assembleProgram() {
     // Conservatively traverse all platform libraries and collect member names.
     // TODO(antonm): ideally we should only collect names of used members,
     // however as of today there are problems with names of some core library
     // interfaces, most probably for interfaces of literals.
     final fixedMemberNames = new Set<String>();
     for (final library in compiler.libraries.values) {
       if (!library.isPlatformLibrary) continue;
       library.implementation.forEachLocalMember((Element element) {
-        if (element.isClass()) {
+        if (element.isClass) {
           ClassElement classElement = element;
           // Make sure we parsed the class to initialize its local members.
           // TODO(smok): Figure out if there is a better way to fill local
           // members.
           element.parseNode(compiler);
           classElement.forEachLocalMember((member) {
             final name = member.name;
             // Skip operator names.
             if (!name.startsWith(r'operator$')) {
               // Fetch name of named constructors and factories if any,
               // otherwise store regular name.
               // TODO(antonm): better way to analyze the name.
               fixedMemberNames.add(name.split(r'$').last);
             }
           });
         }
         // Even class names are added due to a delicate problem we have:
         // if one imports dart:core with a prefix, we cannot tell prefix.name
         // from dynamic invocation (alas!).  So we'd better err on preserving
         // those names.
         fixedMemberNames.add(element.name);
       });
       for (Element export in library.exports) {
         if (!library.isInternalLibrary &&
-            export.getLibrary().isInternalLibrary) {
+            export.library.isInternalLibrary) {
           // If an element of an internal library is reexported by a platform
           // library, we have to import the reexporting library instead of the
           // internal library, because the internal library is an
           // implementation detail of dart2js.
           reexportingLibraries[export] = library;
         }
       }
     }
     // As of now names of named optionals are not renamed. Therefore add all
     // field names used as named optionals into [fixedMemberNames].
     for (final element in resolvedElements.keys) {
-      if (!element.isConstructor()) continue;
+      if (!element.isConstructor) continue;
       Link<Element> optionalParameters =
           element.computeSignature(compiler).optionalParameters;
       for (final optional in optionalParameters) {
         if (optional.kind != ElementKind.FIELD_PARAMETER) continue;
         fixedMemberNames.add(optional.name);
       }
     }
     // The VM will automatically invoke the call method of objects
     // that are invoked as functions. Make sure to not rename that.
     fixedMemberNames.add('call');
     // TODO(antonm): TypeError.srcType and TypeError.dstType are defined in
     // runtime/lib/error.dart. Overall, all DartVM specific libs should be
     // accounted for.
     fixedMemberNames.add('srcType');
     fixedMemberNames.add('dstType');
 
     if (useMirrorHelperLibrary && compiler.mirrorsLibrary != null) {
         mirrorRenamer = new MirrorRenamer(compiler, this);
     } else {
       useMirrorHelperLibrary = false;
     }
 
     /**
      * Tells whether we should output given element. Corelib classes like
      * Object should not be in the resulting code.
      */
     bool shouldOutput(Element element) {
       return (element.kind != ElementKind.VOID
-          && isUserLibrary(element.getLibrary())
+          && isUserLibrary(element.library)
           && !element.isSynthesized
           && element is !AbstractFieldElement)
-          || element.getLibrary() == mirrorHelperLibrary;
+          || element.library == mirrorHelperLibrary;
     }
 
     final elementAsts = new Map<Element, ElementAst>();
 
     ElementAst parse(Element element, TreeElements treeElements) {
       Node node;
       if (!compiler.irBuilder.hasIr(element)) {
         node = element.parseNode(compiler);
       } else {
         ir.FunctionDefinition function = compiler.irBuilder.getIr(element);
@@ skipping 56 matching lines @@
     };
 
     compiler.resolverWorld.instantiatedClasses.forEach(
         (ClassElement classElement) {
       if (shouldOutput(classElement)) addClass(classElement);
     });
     resolvedElements.forEach((element, treeElements) {
       if (!shouldOutput(element) || treeElements == null) return;
       ElementAst elementAst = parse(element, treeElements);
 
-      if (element.isMember()) {
-        ClassElement enclosingClass = element.getEnclosingClass();
-        assert(enclosingClass.isClass());
-        assert(enclosingClass.isTopLevel());
+      if (element.isMember) {
+        ClassElement enclosingClass = element.enclosingClass;
+        assert(enclosingClass.isClass);
+        assert(enclosingClass.isTopLevel);
         assert(shouldOutput(enclosingClass));
         addClass(enclosingClass);
         classMembers[enclosingClass].add(element);
         processElement(element, elementAst);
       } else {
-        if (element.isTopLevel()) {
+        if (element.isTopLevel) {
           addTopLevel(element, elementAst);
         }
       }
     });
     Set<ClassElement> emitNoMembersFor = new Set<ClassElement>();
     usedTypeLiterals.forEach((ClassElement element) {
       if (shouldOutput(element)) {
         if (!topLevelElements.contains(element)) {
           // The class is only referenced by type literals.
           emitNoMembersFor.add(element);
         }
         addClass(element);
       }
     });
 
     // Add synthesized constructors to classes with no resolved constructors,
     // but which originally had any constructor.  That should prevent
     // those classes from being instantiable with default constructor.
     Identifier synthesizedIdentifier = new Identifier(
         new StringToken.fromString(IDENTIFIER_INFO, '', -1));
 
     NextClassElement:
     for (ClassElement classElement in classMembers.keys) {
       if (emitNoMembersFor.contains(classElement)) continue;
       for (Element member in classMembers[classElement]) {
-        if (member.isConstructor()) continue NextClassElement;
+        if (member.isConstructor) continue NextClassElement;
       }
       if (classElement.constructors.isEmpty) continue NextClassElement;
 
       // TODO(antonm): check with AAR team if there is better approach.
       // As an idea: provide template as a Dart code---class C { C.name(); }---
       // and then overwrite necessary parts.
       var classNode = classElement.parseNode(compiler);
       SynthesizedConstructorElementX constructor =
           new SynthesizedConstructorElementX(
               classElement.name, null, classElement, false);
@@ skipping 17 matching lines @@
 
     // Create all necessary placeholders.
     PlaceholderCollector collector =
         new PlaceholderCollector(compiler, fixedMemberNames, elementAsts);
     // Add synthesizedIdentifier to set of unresolved names to rename it to
     // some unused identifier.
     collector.unresolvedNodes.add(synthesizedIdentifier);
     makePlaceholders(element) {
       bool oldUseHelper = useMirrorHelperLibrary;
       useMirrorHelperLibrary = (useMirrorHelperLibrary
-                               && element.getLibrary() != mirrorHelperLibrary);
+                               && element.library != mirrorHelperLibrary);
       collector.collect(element);
       useMirrorHelperLibrary = oldUseHelper;
 
-      if (element.isClass()) {
+      if (element.isClass) {
         classMembers[element].forEach(makePlaceholders);
       }
     }
     topLevelElements.forEach(makePlaceholders);
     // Create renames.
     bool shouldCutDeclarationTypes = forceStripTypes
         || (compiler.enableMinification
             && isSafeToRemoveTypeDeclarations(classMembers));
     renamePlaceholders(
         compiler, collector, renames, imports,
@@ skipping 11 matching lines @@
     if (outputAst) {
       // TODO(antonm): Ideally XML should be a separate backend.
       // TODO(antonm): obey renames and minification, at least as an option.
       StringBuffer sb = new StringBuffer();
       outputElement(element) {
         sb.write(element.parseNode(compiler).toDebugString());
       }
 
       // Emit XML for AST instead of the program.
       for (final topLevel in sortedTopLevels) {
-        if (topLevel.isClass() && !emitNoMembersFor.contains(topLevel)) {
+        if (topLevel.isClass && !emitNoMembersFor.contains(topLevel)) {
           // TODO(antonm): add some class info.
           sortedClassMembers[topLevel].forEach(outputElement);
         } else {
           outputElement(topLevel);
         }
       }
       compiler.assembledCode = '<Program>\n$sb</Program>\n';
       return;
     }
 
     final topLevelNodes = <Node>[];
     for (final element in sortedTopLevels) {
       topLevelNodes.add(elementAsts[element].ast);
-      if (element.isClass() && !element.isMixinApplication) {
+      if (element.isClass && !element.isMixinApplication) {
         final members = <Node>[];
         for (final member in sortedClassMembers[element]) {
           members.add(elementAsts[member].ast);
         }
         memberNodes[elementAsts[element].ast] = members;
       }
     }
 
     if (useMirrorHelperLibrary) {
       mirrorRenamer.addRenames(renames, topLevelNodes, collector);
@@ skipping 40 matching lines @@
         mirrorHelperSymbolsMap = mirrorHelperLibrary.find(
             MirrorRenamer.MIRROR_HELPER_SYMBOLS_MAP_NAME);
       });
     }
     return new Future.value();
   }
 
   void registerTypeLiteral(Element element,
                            Enqueuer enqueuer,
                            TreeElements elements) {
-    if (element.isClass()) {
+    if (element.isClass) {
       usedTypeLiterals.add(element);
     }
   }
 
   void registerStaticSend(Element element, Node node) {
     if (useMirrorHelperLibrary) {
       mirrorRenamer.registerStaticSend(element, node);
     }
   }
 
   void registerMirrorHelperElement(Element element, Node node) {
     if (mirrorHelperLibrary != null
-        && element.getLibrary() == mirrorHelperLibrary) {
+        && element.library == mirrorHelperLibrary) {
       mirrorRenamer.registerHelperElement(element, node);
     }
   }
 
   void registerStaticUse(Element element, Enqueuer enqueuer) {
     if (useMirrorHelperLibrary &&
         element == compiler.mirrorSystemGetNameFunction) {
       enqueuer.addToWorkList(mirrorHelperGetNameFunction);
     }
   }
@@ skipping 50 matching lines @@
   visitNode(Node node) {
     node.visitChildren(this);
   }
 
   visitTypeAnnotation(TypeAnnotation typeAnnotation) {
     TreeElements treeElements = elementAst.treeElements;
     final DartType type = treeElements.getType(typeAnnotation);
     assert(invariant(typeAnnotation, type != null,
         message: "Missing type for type annotation: $treeElements."));
     Element typeElement = type.element;
-    if (typeElement.isTypedef()) newTypedefElementCallback(typeElement);
-    if (typeElement.isClass()) newClassElementCallback(typeElement);
+    if (typeElement.isTypedef) newTypedefElementCallback(typeElement);
+    if (typeElement.isClass) newClassElementCallback(typeElement);
     typeAnnotation.visitChildren(this);
   }
 
   void collect() {
     compiler.withCurrentElement(element, () {
       elementAst.ast.accept(this);
     });
   }
 }
 
 Comparator compareBy(f) => (x, y) => f(x).compareTo(f(y));
 
 List sorted(Iterable l, comparison) {
   final result = new List.from(l);
   result.sort(comparison);
   return result;
 }
 
 compareElements(e0, e1) {
-  int result = compareBy((e) => e.getLibrary().canonicalUri.toString())(e0, e1);
+  int result = compareBy((e) => e.library.canonicalUri.toString())(e0, e1);
   if (result != 0) return result;
-  return compareBy((e) => e.position().charOffset)(e0, e1);
+  return compareBy((e) => e.position.charOffset)(e0, e1);
 }
 
 List<Element> sortElements(Iterable<Element> elements) =>
     sorted(elements, compareElements);
 
 /// [ConstantCompilerTask] for compilation of constants for the Dart backend.
 ///
 /// Since this task needs no distinction between frontend and backend constants
 /// it also serves as the [BackendConstantEnvironment].
 class DartConstantTask extends ConstantCompilerTask
@@ skipping 37 matching lines @@
   }
 
   Constant compileMetadata(MetadataAnnotation metadata,
                            Node node,
                            TreeElements elements) {
     return measure(() {
       return constantCompiler.compileMetadata(metadata, node, elements);
     });
   }
 }