sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart - Issue 266913017: Convert property methods into getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebased Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/mirrors/dart2js_library_mirror.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

index 7440372180068355b8a5618668a175803defb938..1d32ec1b160ca79250996bbb5b2103e3bd495a79 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

@@ -94,12 +94,12 @@ class Dart2JsMethodMirror extends Dart2JsMemberMirror

simpleName = '$simpleName=';

} else if (function.kind == ElementKind.GENERATIVE_CONSTRUCTOR) {

// TODO(johnniwinther): Support detection of redirecting constructors.

- if (function.modifiers.isConst()) {

+ if (function.modifiers.isConst) {

kind = Dart2JsMethodKind.CONST;

} else {

kind = Dart2JsMethodKind.GENERATIVE;

}

- } else if (function.modifiers.isFactory()) {

+ } else if (function.modifiers.isFactory) {

// TODO(johnniwinther): Support detection of redirecting constructors.

kind = Dart2JsMethodKind.FACTORY;

} else if (realName == 'unary-') {

@@ -132,7 +132,7 @@ class Dart2JsMethodMirror extends Dart2JsMemberMirror

bool get isSynthetic => false;

- bool get isStatic => _function.modifiers.isStatic();

+ bool get isStatic => _function.modifiers.isStatic;

List<ParameterMirror> get parameters {

return _parametersFromFunctionSignature(this,

@@ -188,11 +188,11 @@ class Dart2JsFieldMirror extends Dart2JsMemberMirror implements VariableMirror {

bool get isTopLevel => owner is LibraryMirror;

- bool get isStatic => _variable.modifiers.isStatic();

+ bool get isStatic => _variable.modifiers.isStatic;

- bool get isFinal => _variable.modifiers.isFinal();

+ bool get isFinal => _variable.modifiers.isFinal;

- bool get isConst => _variable.modifiers.isConst();

+ bool get isConst => _variable.modifiers.isConst;

TypeMirror get type => owner._getTypeMirror(_variable.type);