Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: sdk/lib/_internal/compiler/implementation/world.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/world.dart
diff --git a/sdk/lib/_internal/compiler/implementation/world.dart b/sdk/lib/_internal/compiler/implementation/world.dart
index 2d5accdb4e2a3725ff9c143d4600e998a3fef19f..9c1fa7dcbb7bb4e220786c6a457780b108e3a070 100644
--- a/sdk/lib/_internal/compiler/implementation/world.dart
+++ b/sdk/lib/_internal/compiler/implementation/world.dart
@@ -141,7 +141,7 @@ class World {
}
bool hasAnyUserDefinedGetter(Selector selector) {
- return allFunctions.filter(selector).any((each) => each.isGetter());
+ return allFunctions.filter(selector).any((each) => each.isGetter);
}
// Returns whether a subclass of [superclass] implements [type].
@@ -180,14 +180,14 @@ class World {
}
void registerUsedElement(Element element) {
- if (element.isInstanceMember() && !element.isAbstract) {
+ if (element.isInstanceMember && !element.isAbstract) {
allFunctions.add(element);
}
}
VariableElement locateSingleField(Selector selector) {
Element result = locateSingleElement(selector);
- return (result != null && result.isField()) ? result : null;
+ return (result != null && result.isField) ? result : null;
}
Element locateSingleElement(Selector selector) {
@@ -206,8 +206,8 @@ class World {
}
bool fieldNeverChanges(Element element) {
- if (!element.isField()) return false;
- if (element.isNative()) {
+ if (!element.isField) return false;
+ if (element.isNative) {
// Some native fields are views of data that may be changed by operations.
// E.g. node.firstChild depends on parentNode.removeBefore(n1, n2).
// TODO(sra): Refine the effect classification so that native effects are
@@ -215,9 +215,9 @@ class World {
return false;
}
- return element.modifiers.isFinal()
- || element.modifiers.isConst()
- || (element.isInstanceMember()
+ return element.modifiers.isFinal
+ || element.modifiers.isConst
+ || (element.isInstanceMember
&& !compiler.resolverWorld.hasInvokedSetter(element, compiler));
}
@@ -228,8 +228,8 @@ class World {
// between a constructor and its body for side effects. This
// implies that currently, the side effects of a constructor body
// contain the side effects of the initializers.
- assert(!element.isGenerativeConstructorBody());
- assert(!element.isField());
+ assert(!element.isGenerativeConstructorBody);
+ assert(!element.isField);
return sideEffects.putIfAbsent(element.declaration, () {
return new SideEffects();
});
@@ -247,18 +247,18 @@ class World {
SideEffects getSideEffectsOfSelector(Selector selector) {
// We're not tracking side effects of closures.
- if (selector.isClosureCall()) return new SideEffects();
+ if (selector.isClosureCall) return new SideEffects();
SideEffects sideEffects = new SideEffects.empty();
for (Element e in allFunctions.filter(selector)) {
- if (e.isField()) {
- if (selector.isGetter()) {
+ if (e.isField) {
+ if (selector.isGetter) {
if (!fieldNeverChanges(e)) {
sideEffects.setDependsOnInstancePropertyStore();
}
- } else if (selector.isSetter()) {
+ } else if (selector.isSetter) {
sideEffects.setChangesInstanceProperty();
} else {
- assert(selector.isCall());
+ assert(selector.isCall);
sideEffects.setAllSideEffects();
sideEffects.setDependsOnSomething();
}

Powered by Google App Engine
This is Rietveld 408576698