sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart - Issue 266913017: Convert property methods into getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebased Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

index 55a374b50dec775d4a2e37b5815d1ca037af6334..57c42339322d0d597375c9cd8e68ab1fd25a3f0d 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

@@ -47,7 +47,7 @@ class RuntimeTypes {

void registerRtiDependency(Element element, Element dependency) {

// We're not dealing with typedef for now.

- if (!element.isClass() || !dependency.isClass()) return;

+ if (!element.isClass || !dependency.isClass) return;

Set<ClassElement> classes =

rtiDependencies.putIfAbsent(element, () => new Set<ClassElement>());

classes.add(dependency);

@@ -396,7 +396,7 @@ class RuntimeTypes {

JavaScriptBackend backend = compiler.backend;

Namer namer = backend.namer;

String name = namer.uniqueNameForTypeConstantElement(type.element);

- if (!type.element.isClass()) return name;

+ if (!type.element.isClass) return name;

InterfaceType interface = type;

Link<DartType> variables = interface.element.typeVariables;

// Type constants can currently only be raw types, so there is no point

@@ -412,7 +412,7 @@ class RuntimeTypes {

// TODO(karlklose): maybe precompute this value and store it in typeChecks?

bool isTrivialSubstitution(ClassElement cls, ClassElement check) {

- if (cls.isClosure()) {

+ if (cls.isClosure) {

// TODO(karlklose): handle closures.

return true;

}

@@ -584,7 +584,7 @@ class RuntimeTypes {

}

static int getTypeVariableIndex(TypeVariableElement variable) {

- ClassElement classElement = variable.getEnclosingClass();

+ ClassElement classElement = variable.enclosingClass;

Link<DartType> variables = classElement.typeVariables;

for (int index = 0; !variables.isEmpty;

index++, variables = variables.tail) {