Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart
index f206e60e025a3349d0cfdd1c6de91a331ff40ddf..1338867d53ef9e8c5211c2f23d5c114af315539e 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart
@@ -201,7 +201,7 @@ class InterceptorEmitter extends CodeEmitterHelper {
jsAst.Statement fastPathForOneShotInterceptor(Selector selector,
Set<ClassElement> classes) {
- if (selector.isOperator()) {
+ if (selector.isOperator) {
String name = selector.name;
if (name == '==') {
return js.statement('''{
@@ -238,7 +238,7 @@ class InterceptorEmitter extends CodeEmitterHelper {
return (~receiver) >>> 0;
''');
}
- } else if (selector.isIndex() || selector.isIndexSet()) {
+ } else if (selector.isIndex || selector.isIndexSet) {
// For an index operation, this code generates:
//
// if (receiver.constructor == Array || typeof receiver == "string") {
@@ -263,7 +263,7 @@ class InterceptorEmitter extends CodeEmitterHelper {
// The index set operator requires a check on its set value in
// checked mode, so we don't optimize the interceptor if the
// compiler has type assertions enabled.
- if (selector.isIndexSet()
+ if (selector.isIndexSet
&& (compiler.enableTypeAssertions || !containsArray)) {
return null;
}
@@ -278,7 +278,7 @@ class InterceptorEmitter extends CodeEmitterHelper {
return left == null ? right : js('# || #', [left, right]);
}
- if (selector.isIndex()) {
+ if (selector.isIndex) {
jsAst.Expression typeCheck;
if (containsArray) {
typeCheck = arrayCheck;
@@ -330,7 +330,7 @@ class InterceptorEmitter extends CodeEmitterHelper {
List<String> parameterNames = <String>[];
parameterNames.add('receiver');
- if (selector.isSetter()) {
+ if (selector.isSetter) {
parameterNames.add('value');
} else {
for (int i = 0; i < selector.argumentCount; i++) {

Powered by Google App Engine
This is Rietveld 408576698