Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/list_tracer.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/inferrer/list_tracer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/inferrer/list_tracer.dart b/sdk/lib/_internal/compiler/implementation/inferrer/list_tracer.dart
index fcb3ae1e987a939382e85d19357bca5fd65c6b1a..907be9e111c017a9c9db830971f9091d87e6f0e0 100644
--- a/sdk/lib/_internal/compiler/implementation/inferrer/list_tracer.dart
+++ b/sdk/lib/_internal/compiler/implementation/inferrer/list_tracer.dart
@@ -172,7 +172,7 @@ class ListTracerVisitor extends TracerVisitor<ListTypeInformation> {
String selectorName = selector.name;
if (currentUser == info.receiver) {
if (!okListSelectorsSet.contains(selectorName)) {
- if (selector.isCall()) {
+ if (selector.isCall) {
int positionalLength = info.arguments.positional.length;
if (selectorName == 'add') {
if (positionalLength == 1) {
@@ -186,9 +186,9 @@ class ListTracerVisitor extends TracerVisitor<ListTypeInformation> {
bailout('Used in a not-ok selector');
return;
}
- } else if (selector.isIndexSet()) {
+ } else if (selector.isIndexSet) {
assignments.add(info.arguments.positional[1]);
- } else if (!selector.isIndex()) {
+ } else if (!selector.isIndex) {
bailout('Used in a not-ok selector');
return;
}
@@ -196,12 +196,12 @@ class ListTracerVisitor extends TracerVisitor<ListTypeInformation> {
if (!doNotChangeLengthSelectorsSet.contains(selectorName)) {
callsGrowableMethod = true;
}
- if (selectorName == 'length' && selector.isSetter()) {
+ if (selectorName == 'length' && selector.isSetter) {
callsGrowableMethod = true;
assignments.add(inferrer.types.nullType);
}
- } else if (selector.isCall() &&
- !info.targets.every((element) => element.isFunction())) {
+ } else if (selector.isCall &&
+ !info.targets.every((element) => element.isFunction)) {
bailout('Passed to a closure');
return;
}

Powered by Google App Engine
This is Rietveld 408576698