Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/resolved_visitor.dart

Issue 266913017: Convert property methods into getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 abstract class ResolvedVisitor<R> extends Visitor<R> { 7 abstract class ResolvedVisitor<R> extends Visitor<R> {
8 final Compiler compiler; 8 final Compiler compiler;
9 TreeElements elements; 9 TreeElements elements;
10 10
11 ResolvedVisitor(this.elements, this.compiler); 11 ResolvedVisitor(this.elements, this.compiler);
12 12
13 R visitSend(Send node) { 13 R visitSend(Send node) {
14 Element element = elements[node]; 14 Element element = elements[node];
15 if (node.isSuperCall) { 15 if (node.isSuperCall) {
16 return visitSuperSend(node); 16 return visitSuperSend(node);
17 } else if (node.isOperator) { 17 } else if (node.isOperator) {
18 return visitOperatorSend(node); 18 return visitOperatorSend(node);
19 } else if (node.isPropertyAccess) { 19 } else if (node.isPropertyAccess) {
20 if (!Elements.isUnresolved(element) && element.impliesType()) { 20 if (!Elements.isUnresolved(element) && element.impliesType) {
21 // A reference to a class literal, typedef or type variable. 21 // A reference to a class literal, typedef or type variable.
22 return visitTypeReferenceSend(node); 22 return visitTypeReferenceSend(node);
23 } else { 23 } else {
24 return visitGetterSend(node); 24 return visitGetterSend(node);
25 } 25 }
26 } else if (element != null && Initializers.isConstructorRedirect(node)) { 26 } else if (element != null && Initializers.isConstructorRedirect(node)) {
27 return visitStaticSend(node); 27 return visitStaticSend(node);
28 } else if (Elements.isClosureSend(node, element)) { 28 } else if (Elements.isClosureSend(node, element)) {
29 return visitClosureSend(node); 29 return visitClosureSend(node);
30 } else if (element == compiler.assertMethod) { 30 } else if (element == compiler.assertMethod) {
31 assert(element != null); 31 assert(element != null);
32 return visitAssert(node); 32 return visitAssert(node);
33 } else { 33 } else {
34 if (Elements.isUnresolved(element)) { 34 if (Elements.isUnresolved(element)) {
35 if (element == null) { 35 if (element == null) {
36 // Example: f() with 'f' unbound. 36 // Example: f() with 'f' unbound.
37 // This can only happen inside an instance method. 37 // This can only happen inside an instance method.
38 return visitDynamicSend(node); 38 return visitDynamicSend(node);
39 } else { 39 } else {
40 return visitStaticSend(node); 40 return visitStaticSend(node);
41 } 41 }
42 } else if (element.impliesType()) { 42 } else if (element.impliesType) {
43 // A reference to a class literal, typedef or type variable. 43 // A reference to a class literal, typedef or type variable.
44 return visitTypeReferenceSend(node); 44 return visitTypeReferenceSend(node);
45 } else if (element.isInstanceMember()) { 45 } else if (element.isInstanceMember) {
46 // Example: f() with 'f' bound to instance method. 46 // Example: f() with 'f' bound to instance method.
47 return visitDynamicSend(node); 47 return visitDynamicSend(node);
48 } else if (!element.isInstanceMember()) { 48 } else if (!element.isInstanceMember) {
49 // Example: A.f() or f() with 'f' bound to a static function. 49 // Example: A.f() or f() with 'f' bound to a static function.
50 // Also includes new A() or new A.named() which is treated like a 50 // Also includes new A() or new A.named() which is treated like a
51 // static call to a factory. 51 // static call to a factory.
52 return visitStaticSend(node); 52 return visitStaticSend(node);
53 } else { 53 } else {
54 internalError("Cannot generate code for send", node: node); 54 internalError("Cannot generate code for send", node: node);
55 return null; 55 return null;
56 } 56 }
57 } 57 }
58 } 58 }
59 59
60 R visitSuperSend(Send node); 60 R visitSuperSend(Send node);
61 R visitOperatorSend(Send node); 61 R visitOperatorSend(Send node);
62 R visitGetterSend(Send node); 62 R visitGetterSend(Send node);
63 R visitClosureSend(Send node); 63 R visitClosureSend(Send node);
64 R visitDynamicSend(Send node); 64 R visitDynamicSend(Send node);
65 R visitStaticSend(Send node); 65 R visitStaticSend(Send node);
66 R visitTypeReferenceSend(Send node); 66 R visitTypeReferenceSend(Send node);
67 R visitAssert(Send node); 67 R visitAssert(Send node);
68 68
69 void internalError(String reason, {Node node}); 69 void internalError(String reason, {Node node});
70 70
71 R visitNode(Node node) { 71 R visitNode(Node node) {
72 internalError("Unhandled node", node: node); 72 internalError("Unhandled node", node: node);
73 return null; 73 return null;
74 } 74 }
75 } 75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698