Shell of implementation for embedded windows. At this point this is

Shell of implementation for embedded windows. At this point this is
just a proof of concept. Next step is going to be pulling code from
the window manager into this. Desktop will likely be renamed to
WindowManager.

At this point just make sure you think I'm not going off into the
weeds.

BUG=none
TEST=none
R=derat@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94733

[Daniel Erat, 2011-07-28 23:00:37]

LGTM after the crippling issues that I pointed out are addressed. :-P

http://codereview.chromium.org/7534002/diff/1/aura/demo/main_win.cc
File aura/demo/main_win.cc (right):

http://codereview.chromium.org/7534002/diff/1/aura/demo/main_win.cc#newcode23
aura/demo/main_win.cc:23: // Trivial WindowDelegate implementation that draws a
red background.
s/red/blue/

http://codereview.chromium.org/7534002/diff/1/aura/desktop.cc
File aura/desktop.cc (right):

http://codereview.chromium.org/7534002/diff/1/aura/desktop.cc#newcode25
aura/desktop.cc:25: for (Windows::iterator i = windows_.begin(); i !=
windows_.end(); ++i)
nit: i think that i've more commonly seen 'it' used for iterators and 'i' for
int indexes in chrome (but feel free to ignore if 'i' for iterators is common)

http://codereview.chromium.org/7534002/diff/1/aura/desktop.h
File aura/desktop.h (right):

http://codereview.chromium.org/7534002/diff/1/aura/desktop.h#newcode45
aura/desktop.h:45: void Show(Window* window);
nit: names like AddWindow() and RemoveWindow() would be more descriptive

http://codereview.chromium.org/7534002/diff/1/aura/desktop_host.h
File aura/desktop_host.h (right):

http://codereview.chromium.org/7534002/diff/1/aura/desktop_host.h#newcode26
aura/desktop_host.h:26: // Creates a new DesktopHost. The caller owners the
returned value.
s/owners/owns/

http://codereview.chromium.org/7534002/diff/1/aura/window.cc
File aura/window.cc (right):

http://codereview.chromium.org/7534002/diff/1/aura/window.cc#newcode74
aura/window.cc:74: gfx::Rect dirty_rect = dirty_rect_.Intersect(
is this Intersect() here to handle a case where |dirty_rect_| extends outside of
bounds(), e.g. the whole window was marked dirty and then it was resized to be
smaller?

http://codereview.chromium.org/7534002/diff/1/aura/window.h
File aura/window.h (right):

http://codereview.chromium.org/7534002/diff/1/aura/window.h#newcode84
aura/window.h:84: // Bounds of the window in the desktops coordinate system.
s/desktops/desktop's/

http://codereview.chromium.org/7534002/diff/1/aura/window_delegate.h
File aura/window_delegate.h (right):

http://codereview.chromium.org/7534002/diff/1/aura/window_delegate.h#newcode14
aura/window_delegate.h:14: // Asks the delegate to paint to the window. The
delegate should callback
s/callback/call back/ (at least, i think of it as being one word for the noun
and two for the verb, like "shutdown" and "login")

[sky, 2011-07-29 15:42:23]

I changed all the others too.

  -Scott

http://codereview.chromium.org/7534002/diff/1/aura/window.cc
File aura/window.cc (right):

http://codereview.chromium.org/7534002/diff/1/aura/window.cc#newcode74
aura/window.cc:74: gfx::Rect dirty_rect = dirty_rect_.Intersect(
On 2011/07/28 23:00:37, Daniel Erat wrote:
> is this Intersect() here to handle a case where |dirty_rect_| extends outside
of
> bounds(), e.g. the whole window was marked dirty and then it was resized to be
> smaller?

Exactly.