Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6894009: Change NavigationEntry's title fields to carry the text direction. (Closed)

Created:
9 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Avi (use Gerrit), kkania, brettw-cc_chromium.org, jam, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

Change NavigationEntry's title fields to carry the text direction. Mark most of the users with a tag pointing at the bug, so they can be fixed incrementally. BUG=27094 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -77 lines) Patch
M base/i18n/rtl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_http_protocol_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_types.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/ui_test_utils.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/site_instance_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry.h View 7 chunks +9 lines, -13 lines 0 comments Download
M content/browser/tab_contents/navigation_entry.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M content/browser/tab_contents/navigation_entry_unittest.cc View 4 chunks +23 lines, -15 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 7 chunks +28 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
9 years, 8 months ago (2011-04-22 00:08:04 UTC) #1
Evan Martin
9 years, 8 months ago (2011-04-22 00:08:21 UTC) #2
Avi (use Gerrit)
LGTM
9 years, 8 months ago (2011-04-22 04:39:35 UTC) #3
brettw
9 years, 8 months ago (2011-04-22 21:18:07 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698