Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: chrome/browser/sessions/session_types.cc

Issue 6894009: Change NavigationEntry's title fields to carry the text direction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_service_unittest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_types.cc
diff --git a/chrome/browser/sessions/session_types.cc b/chrome/browser/sessions/session_types.cc
index f9b1ffdaac2f6bc09728a9b64a2a0378bda948fa..b062699238452a0020f3987790e919a17af291e9 100644
--- a/chrome/browser/sessions/session_types.cc
+++ b/chrome/browser/sessions/session_types.cc
@@ -68,7 +68,10 @@ NavigationEntry* TabNavigation::ToNavigationEntry(int page_id,
profile);
entry->set_page_id(page_id);
- entry->set_title(title_);
+ // TODO(evan): use directionality of title.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
+ entry->set_title(
+ base::i18n::String16WithDirection(title_, base::i18n::LEFT_TO_RIGHT));
entry->set_content_state(state_);
entry->set_has_post_data(type_mask_ & TabNavigation::HAS_POST_DATA);
@@ -78,7 +81,9 @@ NavigationEntry* TabNavigation::ToNavigationEntry(int page_id,
void TabNavigation::SetFromNavigationEntry(const NavigationEntry& entry) {
virtual_url_ = entry.virtual_url();
referrer_ = entry.referrer();
- title_ = entry.title();
+ // TODO(evan): use directionality of title.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
+ title_ = entry.title().string();
state_ = entry.content_state();
transition_ = entry.transition_type();
type_mask_ = entry.has_post_data() ? TabNavigation::HAS_POST_DATA : 0;
« no previous file with comments | « chrome/browser/sessions/session_service_unittest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698