chrome/test/ui_test_utils.cc - Issue 6894009: Change NavigationEntry's title fields to carry the text direction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/ui_test_utils.cc

Issue 6894009: Change NavigationEntry's title fields to carry the text direction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/ui_test_utils.cc

diff --git a/chrome/test/ui_test_utils.cc b/chrome/test/ui_test_utils.cc

index 6ab44290cedd0cdaaaaec274862b1cbf4c637d9a..7c44a1915372ababdd54e832aefda0bb23b61781 100644

--- a/chrome/test/ui_test_utils.cc

+++ b/chrome/test/ui_test_utils.cc

@@ -399,7 +399,9 @@ bool GetCurrentTabTitle(const Browser* browser, string16* title) {

NavigationEntry* last_entry = tab_contents->controller().GetActiveEntry();

if (!last_entry)

return false;

- title->assign(last_entry->GetTitleForDisplay(""));

+ // TODO(evan): use directionality of title.

+ // http://code.google.com/p/chromium/issues/detail?id=27094

+ title->assign(last_entry->GetTitleForDisplay("").string());

return true;

}