chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc - Issue 6894009: Change NavigationEntry's title fields to carry the text direction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

Issue 6894009: Change NavigationEntry's title fields to carry the text direction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

index f7dbd7662ee982db03623ff39930a8155ffd2612..3eef4a60fdee61341b258dfa7e61708c82505e3c 100644

--- a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

@@ -73,7 +73,9 @@ class BackFwdMenuModelTest : public RenderViewHostTestHarness {

void LoadURLAndUpdateState(const char* url, const char* title) {

NavigateAndCommit(GURL(url));

- controller().GetLastCommittedEntry()->set_title(UTF8ToUTF16(title));

+ controller().GetLastCommittedEntry()->set_title(

+ base::i18n::String16WithDirection(UTF8ToUTF16(title),

+ base::i18n::LEFT_TO_RIGHT));

}

// Navigate back or forward the given amount and commits the entry (which

« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model.cc ('k') | chrome/test/ui_test_utils.cc » ('j') | no next file with comments »