Change NavigationEntry's title fields to carry the text direction.

content/browser/site_instance_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stl_util-inl.h"
 #include "base/string16.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/testing_profile.h"
@@ skipping 119 matching lines @@
   int browsingDeleteCounter = 0;
   const GURL url("test:foo");
 
   // Ensure that instances are deleted when their NavigationEntries are gone.
   TestSiteInstance* instance =
       TestSiteInstance::CreateTestSiteInstance(NULL, &siteDeleteCounter,
                                                &browsingDeleteCounter);
   EXPECT_EQ(0, siteDeleteCounter);
 
   NavigationEntry* e1 = new NavigationEntry(instance, 0, url, GURL(),
-                                            string16(),
+                                            base::i18n::String16WithDirection(),
                                             PageTransition::LINK);
 
   // Redundantly setting e1's SiteInstance shouldn't affect the ref count.
   e1->set_site_instance(instance);
   EXPECT_EQ(0, siteDeleteCounter);
 
   // Add a second reference
-  NavigationEntry* e2 = new NavigationEntry(instance, 0, url,
-                                            GURL(), string16(),
+  NavigationEntry* e2 = new NavigationEntry(instance, 0, url, GURL(),
+                                            base::i18n::String16WithDirection(),
                                             PageTransition::LINK);
 
   // Now delete both entries and be sure the SiteInstance goes away.
   delete e1;
   EXPECT_EQ(0, siteDeleteCounter);
   EXPECT_EQ(0, browsingDeleteCounter);
   delete e2;
   EXPECT_EQ(1, siteDeleteCounter);
   // instance is now deleted
   EXPECT_EQ(1, browsingDeleteCounter);
@@ skipping 30 matching lines @@
   const GURL url("test:foo");
 
   SiteInstance* instance1 =
       TestSiteInstance::CreateTestSiteInstance(NULL, &siteDeleteCounter1,
                                                &browsingDeleteCounter);
   SiteInstance* instance2 =
       TestSiteInstance::CreateTestSiteInstance(NULL, &siteDeleteCounter2,
                                                &browsingDeleteCounter);
 
   NavigationEntry* e1 = new NavigationEntry(instance1, 0, url, GURL(),
-                                            string16(),
+                                            base::i18n::String16WithDirection(),
                                             PageTransition::LINK);
   // Clone the entry
   NavigationEntry* e2 = new NavigationEntry(*e1);
 
   // Should be able to change the SiteInstance of the cloned entry.
   e2->set_site_instance(instance2);
 
   // The first SiteInstance should go away after deleting e1, since e2 should
   // no longer be referencing it.
   delete e1;
@@ skipping 358 matching lines @@
       GURL("chrome-extension://baz/bar")));
   EXPECT_EQ(s5a, s5b);
 
   // The derived profiles with the different sites.
   scoped_refptr<SiteInstance> s6a(instance1->GetSiteInstanceForURL(
       GURL("chrome-extension://baz/bar")));
   scoped_refptr<SiteInstance> s6b(instance3->GetSiteInstanceForURL(
       GURL("chrome-extension://foo/boo")));
   EXPECT_NE(s6a, s6b);
 }