Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6344)

Unified Diff: chrome/browser/sessions/base_session_service.cc

Issue 6894009: Change NavigationEntry's title fields to carry the text direction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/base_session_service.cc
diff --git a/chrome/browser/sessions/base_session_service.cc b/chrome/browser/sessions/base_session_service.cc
index b9faaa1ad50e151760037e13bfe5053dc68eab4b..49cbbb65f405714fba20df8362b06d62a67236ec 100644
--- a/chrome/browser/sessions/base_session_service.cc
+++ b/chrome/browser/sessions/base_session_service.cc
@@ -158,7 +158,10 @@ SessionCommand* BaseSessionService::CreateUpdateTabNavigationCommand(
WriteStringToPickle(pickle, &bytes_written, max_state_size,
entry.virtual_url().spec());
- WriteString16ToPickle(pickle, &bytes_written, max_state_size, entry.title());
+ // TODO(evan): use directionality of title.
+ // http://code.google.com/p/chromium/issues/detail?id=27094
+ WriteString16ToPickle(pickle, &bytes_written, max_state_size,
+ entry.title().string());
if (entry.has_post_data()) {
// Remove the form data, it may contain sensitive information.
« no previous file with comments | « chrome/browser/debugger/devtools_http_protocol_handler.cc ('k') | chrome/browser/sessions/session_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698