chrome/browser/debugger/devtools_http_protocol_handler.cc - Issue 6894009: Change NavigationEntry's title fields to carry the text direction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/devtools_http_protocol_handler.cc

Issue 6894009: Change NavigationEntry's title fields to carry the text direction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/debugger/devtools_http_protocol_handler.cc

diff --git a/chrome/browser/debugger/devtools_http_protocol_handler.cc b/chrome/browser/debugger/devtools_http_protocol_handler.cc

index 175de3539da02eaebf7a167a3dfb7066415d7539..514b506235445d5415c9262ba056f5c06d54367b 100644

--- a/chrome/browser/debugger/devtools_http_protocol_handler.cc

+++ b/chrome/browser/debugger/devtools_http_protocol_handler.cc

@@ -253,7 +253,9 @@ static PageList GeneratePageList(

page_info.id = controller.session_id().id();

page_info.attached = client_host != NULL;

page_info.url = entry->url().spec();

- page_info.title = UTF16ToUTF8(entry->title());

+ // TODO(evan): use directionality of title?

+ // http://code.google.com/p/chromium/issues/detail?id=27094

+ page_info.title = UTF16ToUTF8(entry->title().string());

page_info.favicon_url = entry->favicon().url().spec();

page_list.push_back(page_info);

}