Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: content/browser/site_instance_unittest.cc

Issue 6894009: Change NavigationEntry's title fields to carry the text direction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui_test_utils.cc ('k') | content/browser/tab_contents/interstitial_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/site_instance_unittest.cc
diff --git a/content/browser/site_instance_unittest.cc b/content/browser/site_instance_unittest.cc
index b2cb51ca8ace722daf9feb156082d67380e4d31a..12e269da4e7cef6cfbc41188ad2a1def6e5174e0 100644
--- a/content/browser/site_instance_unittest.cc
+++ b/content/browser/site_instance_unittest.cc
@@ -137,7 +137,7 @@ TEST_F(SiteInstanceTest, SiteInstanceDestructor) {
EXPECT_EQ(0, siteDeleteCounter);
NavigationEntry* e1 = new NavigationEntry(instance, 0, url, GURL(),
- string16(),
+ base::i18n::String16WithDirection(),
PageTransition::LINK);
// Redundantly setting e1's SiteInstance shouldn't affect the ref count.
@@ -145,8 +145,8 @@ TEST_F(SiteInstanceTest, SiteInstanceDestructor) {
EXPECT_EQ(0, siteDeleteCounter);
// Add a second reference
- NavigationEntry* e2 = new NavigationEntry(instance, 0, url,
- GURL(), string16(),
+ NavigationEntry* e2 = new NavigationEntry(instance, 0, url, GURL(),
+ base::i18n::String16WithDirection(),
PageTransition::LINK);
// Now delete both entries and be sure the SiteInstance goes away.
@@ -197,7 +197,7 @@ TEST_F(SiteInstanceTest, CloneNavigationEntry) {
&browsingDeleteCounter);
NavigationEntry* e1 = new NavigationEntry(instance1, 0, url, GURL(),
- string16(),
+ base::i18n::String16WithDirection(),
PageTransition::LINK);
// Clone the entry
NavigationEntry* e2 = new NavigationEntry(*e1);
« no previous file with comments | « chrome/test/ui_test_utils.cc ('k') | content/browser/tab_contents/interstitial_page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698