Issue 6733043: Coverity: Pass parameters by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6733043: Coverity: Pass parameters by reference. (Closed)

Created:
9 years, 9 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews, ncarter (slow), jam, idana, Raghu Simha, Erik does not do reviews, kkania, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Coverity: Pass parameters by reference. CID=12947,13008,13087,13144,13280,13479,13480,13574,13575,13576,13580,13594, 13595,14186,14351 BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79595

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -31 lines)			Patch
M	chrome/browser/accessibility/browser_accessibility_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/accessibility_events.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_signin.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_menu_manager.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_menu_manager.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_processes_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_tts_api.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tts_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/search_engines/search_provider_install_data.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_installed_bubble.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_installed_bubble.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/google_chrome_distribution.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper_plugin_delegate_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages