chrome/browser/ui/views/extensions/extension_installed_bubble.cc - Issue 6733043: Coverity: Pass parameters by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble.cc

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/extension_installed_bubble.cc

diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

index 29475c491127f994f5fd999f92e122cf721b9772..a1ab20938a5186124e92562b658bfab1733afc34 100644

--- a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

@@ -235,13 +235,13 @@ class InstalledBubbleContent : public views::View,

void ExtensionInstalledBubble::Show(const Extension* extension,

Browser *browser,

- SkBitmap icon) {

+ const SkBitmap& icon) {

new ExtensionInstalledBubble(extension, browser, icon);

}

ExtensionInstalledBubble::ExtensionInstalledBubble(const Extension* extension,

Browser *browser,

- SkBitmap icon)

+ const SkBitmap& icon)

: extension_(extension),

browser_(browser),

icon_(icon),