Coverity: Pass parameters by reference.

chrome/browser/extensions/extension_menu_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_menu_manager.h"
 
 #include <algorithm>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_event_router.h"
 #include "chrome/browser/extensions/extension_tabs_module.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/common/notification_service.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/favicon_size.h"
 #include "webkit/glue/context_menu.h"
 
 ExtensionMenuItem::ExtensionMenuItem(const Id& id,
-                                     std::string title,
+                                     const std::string& title,
                                      bool checked,
                                      Type type,
                                      const ContextList& contexts)
     : id_(id),
       title_(title),
       type_(type),
       checked_(checked),
       contexts_(contexts),
       parent_id_(0) {
 }
@@ skipping 434 matching lines @@
 // static
 bool ExtensionMenuManager::HasAllowedScheme(const GURL& url) {
   URLPattern pattern(kAllowedSchemes);
   return pattern.SetScheme(url.scheme());
 }
 
 ExtensionMenuItem::Id::Id()
     : profile(NULL), uid(0) {
 }
 
-ExtensionMenuItem::Id::Id(Profile* profile, std::string extension_id, int uid)
+ExtensionMenuItem::Id::Id(Profile* profile,
+                          const std::string& extension_id,
+                          int uid)
     : profile(profile), extension_id(extension_id), uid(uid) {
 }
 
 ExtensionMenuItem::Id::~Id() {
 }
 
 bool ExtensionMenuItem::Id::operator==(const Id& other) const {
   return (profile == other.profile &&
           extension_id == other.extension_id &&
           uid == other.uid);
 }
 
 bool ExtensionMenuItem::Id::operator!=(const Id& other) const {
   return !(*this == other);
 }
 
 bool ExtensionMenuItem::Id::operator<(const Id& other) const {
   if (profile < other.profile)
     return true;
   if (profile == other.profile) {
     if (extension_id < other.extension_id)
       return true;
     if (extension_id == other.extension_id)
       return uid < other.uid;
   }
   return false;
 }