chrome/browser/browser_signin.cc - Issue 6733043: Coverity: Pass parameters by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_signin.cc

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_signin.cc

diff --git a/chrome/browser/browser_signin.cc b/chrome/browser/browser_signin.cc

index 8f9b2ab99dd9ca861c5cc2f3b482ba7f7aee0d85..624f1ebc948121b7dae632e6ea387e464c275413 100644

--- a/chrome/browser/browser_signin.cc

+++ b/chrome/browser/browser_signin.cc

@@ -77,8 +77,8 @@ class BrowserSigninHtml : public HtmlDialogUIDelegate,

public WebUIMessageHandler {

public:

BrowserSigninHtml(BrowserSignin* signin,

- string16 suggested_email,

- string16 login_message);

+ const string16& suggested_email,

+ const string16& login_message);

virtual ~BrowserSigninHtml() {}

// HtmlDialogUIDelegate implementation

@@ -135,8 +135,8 @@ class BrowserSigninHtml : public HtmlDialogUIDelegate,

};

BrowserSigninHtml::BrowserSigninHtml(BrowserSignin* signin,

- string16 suggested_email,

- string16 login_message)

+ const string16& suggested_email,

+ const string16& login_message)

: signin_(signin),

suggested_email_(suggested_email),

login_message_(login_message),