Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Side by Side Diff: chrome/browser/sync/profile_sync_service_harness.h

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 const std::string& reason); 180 const std::string& reason);
181 181
182 // Returns true if the sync client has no unsynced items. 182 // Returns true if the sync client has no unsynced items.
183 bool IsSynced(); 183 bool IsSynced();
184 184
185 // Returns true if this client has downloaded all the items that the 185 // Returns true if this client has downloaded all the items that the
186 // other client has. 186 // other client has.
187 bool MatchesOtherClient(ProfileSyncServiceHarness* partner); 187 bool MatchesOtherClient(ProfileSyncServiceHarness* partner);
188 188
189 // Logs message with relevant info about client's sync state (if available). 189 // Logs message with relevant info about client's sync state (if available).
190 void LogClientInfo(std::string message); 190 void LogClientInfo(const std::string& message);
191 191
192 // Gets the current progress indicator of the current sync session 192 // Gets the current progress indicator of the current sync session
193 // for a particular datatype. 193 // for a particular datatype.
194 std::string GetUpdatedTimestamp(syncable::ModelType model_type); 194 std::string GetUpdatedTimestamp(syncable::ModelType model_type);
195 195
196 // When in WAITING_FOR_ENCRYPTION state, we check to see if this type is now 196 // When in WAITING_FOR_ENCRYPTION state, we check to see if this type is now
197 // encrypted to determine if we're done. 197 // encrypted to determine if we're done.
198 syncable::ModelType waiting_for_encryption_type_; 198 syncable::ModelType waiting_for_encryption_type_;
199 199
200 WaitState wait_state_; 200 WaitState wait_state_;
201 201
202 Profile* profile_; 202 Profile* profile_;
203 ProfileSyncService* service_; 203 ProfileSyncService* service_;
204 204
205 // The harness of the client whose update progress marker we're expecting 205 // The harness of the client whose update progress marker we're expecting
206 // eventually match. 206 // eventually match.
207 ProfileSyncServiceHarness* timestamp_match_partner_; 207 ProfileSyncServiceHarness* timestamp_match_partner_;
208 208
209 // Credentials used for GAIA authentication. 209 // Credentials used for GAIA authentication.
210 std::string username_; 210 std::string username_;
211 std::string password_; 211 std::string password_;
212 212
213 // Client ID, used for logging purposes. 213 // Client ID, used for logging purposes.
214 int id_; 214 int id_;
215 215
216 DISALLOW_COPY_AND_ASSIGN(ProfileSyncServiceHarness); 216 DISALLOW_COPY_AND_ASSIGN(ProfileSyncServiceHarness);
217 }; 217 };
218 218
219 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_ 219 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_HARNESS_H_
OLDNEW
« no previous file with comments | « chrome/browser/search_engines/search_provider_install_data.cc ('k') | chrome/browser/sync/profile_sync_service_harness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698