Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/search_engines/search_provider_install_data.cc

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tts_api.cc ('k') | chrome/browser/sync/profile_sync_service_harness.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/search_provider_install_data.cc
diff --git a/chrome/browser/search_engines/search_provider_install_data.cc b/chrome/browser/search_engines/search_provider_install_data.cc
index d7086f7c52e4bfcffdd15c79aeccafbd066c628c..6ef9bef12657abb4fa977659cfd8ecfb6a4236e2 100644
--- a/chrome/browser/search_engines/search_provider_install_data.cc
+++ b/chrome/browser/search_engines/search_provider_install_data.cc
@@ -30,7 +30,7 @@ namespace {
// Implementation of SearchTermsData that may be used on the I/O thread.
class IOThreadSearchTermsData : public SearchTermsData {
public:
- explicit IOThreadSearchTermsData(std::string google_base_url);
+ explicit IOThreadSearchTermsData(const std::string& google_base_url);
// Implementation of SearchTermsData.
virtual std::string GoogleBaseURLValue() const;
@@ -48,8 +48,8 @@ class IOThreadSearchTermsData : public SearchTermsData {
DISALLOW_COPY_AND_ASSIGN(IOThreadSearchTermsData);
};
-IOThreadSearchTermsData::IOThreadSearchTermsData(std::string google_base_url)
- : google_base_url_(google_base_url) {
+IOThreadSearchTermsData::IOThreadSearchTermsData(
+ const std::string& google_base_url) : google_base_url_(google_base_url) {
}
std::string IOThreadSearchTermsData::GoogleBaseURLValue() const {
« no previous file with comments | « chrome/browser/extensions/extension_tts_api.cc ('k') | chrome/browser/sync/profile_sync_service_harness.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698