chrome/browser/extensions/extension_tts_api.cc - Issue 6733043: Coverity: Pass parameters by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tts_api.cc

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tts_api.cc

diff --git a/chrome/browser/extensions/extension_tts_api.cc b/chrome/browser/extensions/extension_tts_api.cc

index c618db344fbb765f6a59b0568760ee38272c4d43..809ea450f047ae5ec28730a27e95bd9f290585d8 100644

--- a/chrome/browser/extensions/extension_tts_api.cc

+++ b/chrome/browser/extensions/extension_tts_api.cc

@@ -257,7 +257,7 @@ void ExtensionTtsController::Stop() {

}

void ExtensionTtsController::OnSpeechFinished(

- int request_id, std::string error_message) {

+ int request_id, const std::string& error_message) {

// We may sometimes receive completion callbacks "late", after we've

// already finished the utterance (for example because another utterance

// interrupted or we got a call to Stop). It's also possible that a buggy