Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/extensions/extension_processes_api.cc

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_processes_api.h" 5 #include "chrome/browser/extensions/extension_processes_api.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/json/json_writer.h" 8 #include "base/json/json_writer.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
11 #include "base/task.h" 11 #include "base/task.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 14
15 #include "chrome/browser/extensions/extension_event_router.h" 15 #include "chrome/browser/extensions/extension_event_router.h"
16 #include "chrome/browser/extensions/extension_processes_api_constants.h" 16 #include "chrome/browser/extensions/extension_processes_api_constants.h"
17 #include "chrome/browser/extensions/extension_tabs_module.h" 17 #include "chrome/browser/extensions/extension_tabs_module.h"
18 #include "chrome/browser/extensions/extension_tabs_module_constants.h" 18 #include "chrome/browser/extensions/extension_tabs_module_constants.h"
19 #include "chrome/browser/profiles/profile.h" 19 #include "chrome/browser/profiles/profile.h"
20 #include "chrome/browser/task_manager/task_manager.h" 20 #include "chrome/browser/task_manager/task_manager.h"
21 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 21 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
22 #include "chrome/common/extensions/extension_error_utils.h" 22 #include "chrome/common/extensions/extension_error_utils.h"
23 #include "content/browser/renderer_host/render_process_host.h" 23 #include "content/browser/renderer_host/render_process_host.h"
24 #include "content/browser/tab_contents/tab_contents.h" 24 #include "content/browser/tab_contents/tab_contents.h"
25 #include "content/common/notification_type.h" 25 #include "content/common/notification_type.h"
26 26
27 namespace keys = extension_processes_api_constants; 27 namespace keys = extension_processes_api_constants;
28 28
29 DictionaryValue* CreateProcessValue(int process_id, 29 DictionaryValue* CreateProcessValue(int process_id,
30 std::string type, 30 const std::string& type,
31 double cpu, 31 double cpu,
32 int64 net, 32 int64 net,
33 int64 pr_mem, 33 int64 pr_mem,
34 int64 sh_mem) { 34 int64 sh_mem) {
35 DictionaryValue* result = new DictionaryValue(); 35 DictionaryValue* result = new DictionaryValue();
36 result->SetInteger(keys::kIdKey, process_id); 36 result->SetInteger(keys::kIdKey, process_id);
37 result->SetString(keys::kTypeKey, type); 37 result->SetString(keys::kTypeKey, type);
38 result->SetDouble(keys::kCpuKey, cpu); 38 result->SetDouble(keys::kCpuKey, cpu);
39 result->SetDouble(keys::kNetworkKey, static_cast<double>(net)); 39 result->SetDouble(keys::kNetworkKey, static_cast<double>(net));
40 result->SetDouble(keys::kPrivateMemoryKey, static_cast<double>(pr_mem)); 40 result->SetDouble(keys::kPrivateMemoryKey, static_cast<double>(pr_mem));
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 base::IntToString(tab_id)); 169 base::IntToString(tab_id));
170 return false; 170 return false;
171 } 171 }
172 172
173 // Return the process ID of the tab as an integer. 173 // Return the process ID of the tab as an integer.
174 int id = base::GetProcId(contents->tab_contents()-> 174 int id = base::GetProcId(contents->tab_contents()->
175 GetRenderProcessHost()->GetHandle()); 175 GetRenderProcessHost()->GetHandle());
176 result_.reset(Value::CreateIntegerValue(id)); 176 result_.reset(Value::CreateIntegerValue(id));
177 return true; 177 return true;
178 } 178 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_menu_manager.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698