Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_processes_api.cc ('k') | chrome/browser/extensions/extension_tts_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index 5b062d35eb8391f0683682ac16c690b018db0d0b..fae2ce7eb9ddeaa2e4bae7b1feb4f1d997ee8694 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -70,7 +70,7 @@ static bool GetTabById(int tab_id, Profile* profile,
// (chrome-extension://<id>/). Using the source frame url would be more correct,
// but because the api shipped with urls resolved relative to their extension
// base, we decided it wasn't worth breaking existing extensions to fix.
-static GURL ResolvePossiblyRelativeURL(std::string url_string,
+static GURL ResolvePossiblyRelativeURL(const std::string& url_string,
const Extension* extension);
// Return the type name for a browser window type.
@@ -1228,6 +1228,7 @@ void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
}
// static helpers
+// TODO(jhawkins): Move these to unnamed namespace and remove static modifier.
static Browser* GetBrowserInProfileWithId(Profile* profile,
const int window_id,
@@ -1280,7 +1281,7 @@ static std::string GetWindowTypeText(Browser::Type type) {
return keys::kWindowTypeValueNormal;
}
-static GURL ResolvePossiblyRelativeURL(std::string url_string,
+static GURL ResolvePossiblyRelativeURL(const std::string& url_string,
const Extension* extension) {
GURL url = GURL(url_string);
if (!url.is_valid())
« no previous file with comments | « chrome/browser/extensions/extension_processes_api.cc ('k') | chrome/browser/extensions/extension_tts_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698