Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: chrome/browser/extensions/extension_menu_manager.h

Issue 6733043: Coverity: Pass parameters by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_signin.cc ('k') | chrome/browser/extensions/extension_menu_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_menu_manager.h
diff --git a/chrome/browser/extensions/extension_menu_manager.h b/chrome/browser/extensions/extension_menu_manager.h
index 1834b41c9f552598462339cbdc2b9320feb235d6..c0e815d17a09abd2e472a092a442fdff0ba18cba 100644
--- a/chrome/browser/extensions/extension_menu_manager.h
+++ b/chrome/browser/extensions/extension_menu_manager.h
@@ -36,7 +36,7 @@ class ExtensionMenuItem {
// An Id uniquely identifies a context menu item registered by an extension.
struct Id {
Id();
- Id(Profile* profile, std::string extension_id, int uid);
+ Id(Profile* profile, const std::string& extension_id, int uid);
~Id();
bool operator==(const Id& other) const;
@@ -99,7 +99,10 @@ class ExtensionMenuItem {
uint32 value_; // A bitmask of Context values.
};
- ExtensionMenuItem(const Id& id, std::string title, bool checked, Type type,
+ ExtensionMenuItem(const Id& id,
+ const std::string& title,
+ bool checked,
+ Type type,
const ContextList& contexts);
virtual ~ExtensionMenuItem();
« no previous file with comments | « chrome/browser/browser_signin.cc ('k') | chrome/browser/extensions/extension_menu_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698