Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

BUG=carnitas
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76992

[Elliot Glaysher, 2011-03-04 19:10:55]

If someone fixes the rest of the implicit virtual problems, we can throw up a
linux_views clang bot easily now.

[Nico, 2011-03-04 19:42:17]

FYI: Such a bot is already up at
http://build.chromium.org/p/chromium.fyi/console , but it's not
completely green yet. Once I'm done with that (maybe today, probably
not), I'll turn on your plugin, and if things look good, I'll move it
to the main waterfall (should be there monday in a week).

Will review this in a minute.

On Fri, Mar 4, 2011 at 11:10 AM,  <erg@chromium.org> wrote:
> Reviewers: Nico, Ben Goodger,
>
> Message:
> If someone fixes the rest of the implicit virtual problems, we can throw up
> a
> linux_views clang bot easily now.
>
> Description:
> Do all OOLing in the views code. linux_views now builds clean with the clang
> plugin.
>
> BUG=carnitas
> TEST=compiles
>
> Please review this at http://codereview.chromium.org/6622002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/views/accessible_pane_view.h
>  M chrome/browser/ui/views/accessible_pane_view.cc
>  M chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
>  M chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
>  M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
>  M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
>  M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
>  M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
>  M chrome/browser/ui/views/clear_browsing_data.h
>  M chrome/browser/ui/views/clear_browsing_data.cc
>  M chrome/browser/ui/views/download_shelf_view.h
>  M chrome/browser/ui/views/download_shelf_view.cc
>  M chrome/browser/ui/views/extensions/extension_installed_bubble.h
>  M chrome/browser/ui/views/extensions/extension_installed_bubble.cc
>  M chrome/browser/ui/views/frame/browser_bubble_host.h
>  M chrome/browser/ui/views/frame/browser_bubble_host.cc
>  M chrome/browser/ui/views/frame/browser_view.h
>  M chrome/browser/ui/views/info_bubble.h
>  M chrome/browser/ui/views/info_bubble.cc
>  M chrome/browser/ui/views/js_modal_dialog_views.h
>  M chrome/browser/ui/views/js_modal_dialog_views.cc
>  M chrome/browser/ui/views/location_bar/content_setting_image_view.h
>  M chrome/browser/ui/views/location_bar/content_setting_image_view.cc
>  M chrome/browser/ui/views/location_bar/location_bar_view.h
>  M chrome/browser/ui/views/location_bar/location_bar_view.cc
>  M chrome/browser/ui/views/location_bar/star_view.h
>  M chrome/browser/ui/views/location_bar/star_view.cc
>  M chrome/browser/ui/views/options/options_page_view.h
>  M chrome/browser/ui/views/options/options_page_view.cc
>  M chrome/browser/ui/views/page_info_bubble_view.h
>  M chrome/browser/ui/views/page_info_bubble_view.cc
>  M chrome/browser/ui/views/sad_tab_view.h
>  M chrome/browser/ui/views/sad_tab_view.cc
>  M chrome/browser/ui/views/tabs/base_tab.h
>  M chrome/browser/ui/views/tabs/base_tab.cc
>  M chrome/browser/ui/views/tabs/base_tab_strip.h
>  M chrome/browser/ui/views/tabs/base_tab_strip.cc
>  M chrome/browser/ui/views/tabs/tab.h
>  M chrome/browser/ui/views/tabs/tab.cc
>  M chrome/browser/ui/views/tabs/tab_renderer_data.h
>  A chrome/browser/ui/views/tabs/tab_renderer_data.cc
>  M chrome/browser/ui/views/tabs/tab_strip.h
>  M chrome/browser/ui/views/theme_install_bubble_view.h
>  M chrome/chrome_browser.gypi
>  M ui/views/focus/focus_manager.h
>  M ui/views/focus/focus_manager.cc
>  M views/controls/label.h
>  M views/controls/label.cc
>  M views/controls/menu/menu_2.h
>  M views/controls/menu/menu_2.cc
>  M views/controls/menu/menu_config.h
>  M views/controls/menu/menu_config.cc
>  M views/controls/menu/menu_controller.h
>  M views/controls/menu/menu_controller.cc
>  M views/controls/menu/menu_delegate.h
>  A views/controls/menu/menu_delegate.cc
>  M views/controls/menu/menu_host_gtk.h
>  M views/controls/menu/menu_item_view.h
>  M views/controls/menu/menu_item_view.cc
>  M views/controls/menu/menu_separator.h
>  M views/controls/menu/submenu_view.h
>  M views/controls/message_box_view.h
>  M views/controls/message_box_view.cc
>  M views/controls/throbber.h
>  M views/controls/throbber.cc
>  M views/focus/focus_manager.h
>  M views/focus/focus_manager.cc
>  M views/view.h
>  M views/view.cc
>  M views/views.gyp
>  M views/widget/default_theme_provider.h
>  M views/widget/default_theme_provider.cc
>  M views/widget/widget_gtk.h
>  M views/widget/widget_gtk.cc
>  M views/window/client_view.h
>  M views/window/client_view.cc
>  M views/window/dialog_client_view.h
>  M views/window/dialog_client_view.cc
>  M views/window/dialog_delegate.h
>  M views/window/dialog_delegate.cc
>  M views/window/non_client_view.h
>  M views/window/non_client_view.cc
>  M views/window/window.h
>  M views/window/window.cc
>  M views/window/window_delegate.h
>  M views/window/window_delegate.cc
>  M views/window/window_gtk.h
>  M views/window/window_gtk.cc
>
>
>

[Nico, 2011-03-04 22:53:02]

LG

http://codereview.chromium.org/6622002/diff/1/chrome/browser/ui/views/autocom...
File chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc (right):

http://codereview.chromium.org/6622002/diff/1/chrome/browser/ui/views/autocom...
chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc:56: // in
logical order.
align with // on prev line

http://codereview.chromium.org/6622002/diff/1/views/controls/menu/menu_delega...
File views/controls/menu/menu_delegate.h (left):

http://codereview.chromium.org/6622002/diff/1/views/controls/menu/menu_delega...
views/controls/menu/menu_delegate.h:137: virtual bool CanDrop(MenuItemView*
menu, const OSExchangeData& data) {
I think I renamed this and the 2 methods below to CanDropForView etc; make sure
this merges correctly

http://codereview.chromium.org/6622002/diff/1/views/controls/menu/menu_host_g...
File views/controls/menu/menu_host_gtk.h (right):

http://codereview.chromium.org/6622002/diff/1/views/controls/menu/menu_host_g...
views/controls/menu/menu_host_gtk.h:24: virtual void Init(gfx::NativeWindow
parent,
I renamed this to InitMenuHost