chrome/browser/ui/views/bookmarks/bookmark_bar_view.h - Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc ('K') | « chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | views/controls/menu/menu_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

index 5737e7cae481c4304018a4495a50e99694c15407..9879a6687a4107df3d1037afe40f5382a823297e 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

@@ -113,9 +113,7 @@ class BookmarkBarView : public DetachableToolbarView,

virtual bool IsDetached() const;

virtual bool IsOnTop() const;

virtual double GetAnimationValue() const;

- virtual int GetToolbarOverlap() const {

- return GetToolbarOverlap(false);

- }

+ virtual int GetToolbarOverlap() const;

// View methods:

virtual gfx::Size GetPreferredSize();

@@ -181,8 +179,8 @@ class BookmarkBarView : public DetachableToolbarView,

bool is_animating();

// SlideAnimationDelegate implementation.

- void AnimationProgressed(const ui::Animation* animation);

- void AnimationEnded(const ui::Animation* animation);

+ virtual void AnimationProgressed(const ui::Animation* animation);

+ virtual void AnimationEnded(const ui::Animation* animation);

// BookmarkMenuController::Observer

virtual void BookmarkMenuDeleted(BookmarkMenuController* controller);