chrome/browser/ui/views/location_bar/star_view.h - Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/location_bar/star_view.h

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc ('K') | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/location_bar/star_view.cc » ('j') | views/controls/menu/menu_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_

6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_	6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_

7 #pragma once	7 #pragma once

8	8

9 #include "chrome/browser/ui/views/info_bubble.h"	9 #include "chrome/browser/ui/views/info_bubble.h"

10 #include "views/controls/image_view.h"	10 #include "views/controls/image_view.h"

(...skipping 19 matching lines...) Expand all Loading...
30 virtual AccessibilityTypes::Role GetAccessibleRole();	30 virtual AccessibilityTypes::Role GetAccessibleRole();

31 virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip);	31 virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip);

32 virtual bool OnMousePressed(const views::MouseEvent& event);	32 virtual bool OnMousePressed(const views::MouseEvent& event);

33 virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled);	33 virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled);

34 virtual bool OnKeyPressed(const views::KeyEvent& e);	34 virtual bool OnKeyPressed(const views::KeyEvent& e);

35	35

36 // InfoBubbleDelegate overrides:	36 // InfoBubbleDelegate overrides:

37 virtual void InfoBubbleClosing(InfoBubble* info_bubble,	37 virtual void InfoBubbleClosing(InfoBubble* info_bubble,

38 bool closed_by_escape);	38 bool closed_by_escape);

39 virtual bool CloseOnEscape();	39 virtual bool CloseOnEscape();

40 virtual bool FadeInOnShow() { return false; }	40 virtual bool FadeInOnShow();

41	41

42 // The CommandUpdater for the Browser object that owns the location bar.	42 // The CommandUpdater for the Browser object that owns the location bar.

43 CommandUpdater* command_updater_;	43 CommandUpdater* command_updater_;

44	44

45 DISALLOW_IMPLICIT_CONSTRUCTORS(StarView);	45 DISALLOW_IMPLICIT_CONSTRUCTORS(StarView);

46 };	46 };

47	47

48 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_	48 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_

OLD	NEW