Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Side by Side Diff: chrome/browser/ui/views/tabs/base_tab_strip.cc

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/tabs/base_tab_strip.h" 5 #include "chrome/browser/ui/views/tabs/base_tab_strip.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/ui/view_ids.h" 8 #include "chrome/browser/ui/view_ids.h"
9 #include "chrome/browser/ui/views/tabs/dragged_tab_controller.h" 9 #include "chrome/browser/ui/views/tabs/dragged_tab_controller.h"
10 #include "chrome/browser/ui/views/tabs/tab_strip_controller.h" 10 #include "chrome/browser/ui/views/tabs/tab_strip_controller.h"
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 true); 383 true);
384 } 384 }
385 385
386 void BaseTabStrip::StartMiniTabAnimation() { 386 void BaseTabStrip::StartMiniTabAnimation() {
387 PrepareForAnimation(); 387 PrepareForAnimation();
388 388
389 GenerateIdealBounds(); 389 GenerateIdealBounds();
390 AnimateToIdealBounds(); 390 AnimateToIdealBounds();
391 } 391 }
392 392
393 bool BaseTabStrip::ShouldHighlightCloseButtonAfterRemove() {
394 return true;
395 }
396
393 void BaseTabStrip::RemoveAndDeleteTab(BaseTab* tab) { 397 void BaseTabStrip::RemoveAndDeleteTab(BaseTab* tab) {
394 int tab_data_index = TabIndexOfTab(tab); 398 int tab_data_index = TabIndexOfTab(tab);
395 399
396 DCHECK(tab_data_index != -1); 400 DCHECK(tab_data_index != -1);
397 401
398 // Remove the Tab from the TabStrip's list... 402 // Remove the Tab from the TabStrip's list...
399 tab_data_.erase(tab_data_.begin() + tab_data_index); 403 tab_data_.erase(tab_data_.begin() + tab_data_index);
400 404
401 delete tab; 405 delete tab;
402 } 406 }
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 487
484 StopAnimating(false); 488 StopAnimating(false);
485 489
486 GenerateIdealBounds(); 490 GenerateIdealBounds();
487 491
488 for (int i = 0; i < tab_count(); ++i) 492 for (int i = 0; i < tab_count(); ++i)
489 tab_data_[i].tab->SetBoundsRect(tab_data_[i].ideal_bounds); 493 tab_data_[i].tab->SetBoundsRect(tab_data_[i].ideal_bounds);
490 494
491 SchedulePaint(); 495 SchedulePaint();
492 } 496 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698