Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: chrome/browser/ui/views/autocomplete/autocomplete_result_view.h

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
diff --git a/chrome/browser/ui/views/autocomplete/autocomplete_result_view.h b/chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
index a8e7673633d4d073b7956f691b437eeef6bbe3c4..1fba8a5c8fedc63f9bbead406aa8649825575831 100644
--- a/chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
+++ b/chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
@@ -80,28 +80,10 @@ class AutocompleteResultView : public views::View {
int text_vertical_padding_;
private:
- // Precalculated data used to draw the portion of a match classification that
- // fits entirely within one run.
- struct ClassificationData {
- string16 text;
- const gfx::Font* font;
- SkColor color;
- int pixel_width;
- };
+ struct ClassificationData;
typedef std::vector<ClassificationData> Classifications;
- // Precalculated data used to draw a complete visual run within the match.
- // This will include all or part of at leasdt one, and possibly several,
- // classifications.
- struct RunData {
- size_t run_start; // Offset within the match text where this run begins.
- int visual_order; // Where this run occurs in visual order. The earliest
- // run drawn is run 0.
- bool is_rtl;
- int pixel_width;
- Classifications classifications; // Classification pieces within this run,
- // in logical order.
- };
+ struct RunData;
typedef std::vector<RunData> Runs;
// Predicate functions for use when sorting the runs.

Powered by Google App Engine
This is Rietveld 408576698