views/controls/menu/menu_controller.h - Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/menu/menu_controller.h

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc ('K') | « views/controls/menu/menu_config.cc ('k') | views/controls/menu/menu_controller.cc » ('j') | views/controls/menu/menu_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: views/controls/menu/menu_controller.h

diff --git a/views/controls/menu/menu_controller.h b/views/controls/menu/menu_controller.h

index 2da3a4b9d8d0c40a3fe98a01992abc49c7db298c..dfd68b4256de5312870033156ce692d7502207fe 100644

--- a/views/controls/menu/menu_controller.h

+++ b/views/controls/menu/menu_controller.h

@@ -131,7 +131,8 @@ class MenuController : public MessageLoopForUI::Dispatcher {

// Tracks selection information.

struct State {

- State() : item(NULL), submenu_open(false) {}

+ State();

+ ~State();

// The selected menu item.

MenuItemView* item;