chrome/browser/ui/views/extensions/extension_installed_bubble.cc - Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble.cc

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc ('K') | « chrome/browser/ui/views/extensions/extension_installed_bubble.h ('k') | chrome/browser/ui/views/frame/browser_bubble_host.h » ('j') | views/controls/menu/menu_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_installed_bubble.cc

diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

index 9ea61f316d20351fe8121c3424bee651ab12d2e4..08d7c6c4d04dc59ecd0823bb9e6dde55aa57146d 100644

--- a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc

@@ -270,6 +270,8 @@ ExtensionInstalledBubble::ExtensionInstalledBubble(const Extension* extension,

Source<Profile>(browser->profile()));

}

+ExtensionInstalledBubble::~ExtensionInstalledBubble() {}

void ExtensionInstalledBubble::Observe(NotificationType type,

const NotificationSource& source,

const NotificationDetails& details) {

@@ -370,3 +372,11 @@ void ExtensionInstalledBubble::InfoBubbleClosing(InfoBubble* info_bubble,

Release(); // Balanced in ctor.

}

+bool ExtensionInstalledBubble::CloseOnEscape() {

+ return true;

+bool ExtensionInstalledBubble::FadeInOnShow() {

+ return true;