chrome/browser/ui/views/tabs/base_tab.h - Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/base_tab.h

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc ('K') | « chrome/browser/ui/views/sad_tab_view.cc ('k') | chrome/browser/ui/views/tabs/base_tab.cc » ('j') | views/controls/menu/menu_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/base_tab.h

diff --git a/chrome/browser/ui/views/tabs/base_tab.h b/chrome/browser/ui/views/tabs/base_tab.h

index 8a43f0690603b74d74c1773778ee30f2cb7046e0..74293a73b874e379f7592a2b12a54ab94bc598eb 100644

--- a/chrome/browser/ui/views/tabs/base_tab.h

+++ b/chrome/browser/ui/views/tabs/base_tab.h

@@ -136,13 +136,9 @@ class BaseTab : public ui::AnimationDelegate,

virtual const gfx::Rect& GetTitleBounds() const = 0;

virtual const gfx::Rect& GetIconBounds() const = 0;

- virtual int loading_animation_frame() const {

- return loading_animation_frame_;

- }

- virtual bool should_display_crashed_favicon() const {

- return should_display_crashed_favicon_;

- }

- virtual int fav_icon_hiding_offset() const { return fav_icon_hiding_offset_; }

+ virtual int loading_animation_frame() const;

+ virtual bool should_display_crashed_favicon() const;

+ virtual int fav_icon_hiding_offset() const;

static gfx::Font* font() { return font_; }

static int font_height() { return font_height_; }