chrome/browser/ui/views/extensions/extension_installed_bubble.h - Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble.h

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc ('K') | « chrome/browser/ui/views/download_shelf_view.cc ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble.cc » ('j') | views/controls/menu/menu_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_installed_bubble.h

diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble.h b/chrome/browser/ui/views/extensions/extension_installed_bubble.h

index ff15b6ddacc748ec7a1a0ba99e12b28c26d24b10..20060ebfa564aa603424a99b251e6148a1d40171 100644

--- a/chrome/browser/ui/views/extensions/extension_installed_bubble.h

+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble.h

@@ -54,7 +54,7 @@ class ExtensionInstalledBubble

ExtensionInstalledBubble(const Extension* extension, Browser *browser,

SkBitmap icon);

- ~ExtensionInstalledBubble() {}

+ virtual ~ExtensionInstalledBubble();

// Shows the bubble. Called internally via PostTask.

void ShowInternal();

@@ -67,8 +67,8 @@ class ExtensionInstalledBubble

// InfoBubbleDelegate

virtual void InfoBubbleClosing(InfoBubble* info_bubble,

bool closed_by_escape);

- virtual bool CloseOnEscape() { return true; }

- virtual bool FadeInOnShow() { return true; }

+ virtual bool CloseOnEscape();

+ virtual bool FadeInOnShow();

const Extension* extension_;

Browser* browser_;